Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1009611imm; Wed, 25 Jul 2018 09:54:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeVh+mC5W/qdtvY4d2l5x49dwQ/p2tm9LZUvd31qwC7gc9N3rr66nkOyUEbKXrxz1DywM9u X-Received: by 2002:a63:2704:: with SMTP id n4-v6mr20788204pgn.87.1532537651913; Wed, 25 Jul 2018 09:54:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532537651; cv=none; d=google.com; s=arc-20160816; b=I9zFSzCmfz2sGh4NjBrLBaY+MDMJ+oa2eVNYYDm0tPGIJ90T1tN6zVi8tG2qI4wT+i SyUcP6BuE7sCXJn4eCvNG8Q1NZ6Dzo0oRAeCa2IdFE0pVH4vLw3wpkVuOhrrlUJJda4q 4qLhsx0dqFNB98iMaUF6H+k7OG2qZW0TNub0q2DX1DsaE1nMxUx8J9PPDnQwPlDvMhMY vjy+IIzOOpPVYop2cbHwLJIsfFMDXAqDMI2GP4BHYocmkteNmrw/n8GYcFpAggtq/3B7 WMTpOr8z9um6lfCEdBmsHZTkX7PTrZmE4Oqr1y1ruMF0PbHjDRkCtoBmRpiVvU8Rd/Gl NQ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=IImg7MCjyzTAi+iW6O//WdJRY8vIIYXkbE6/HHewhjc=; b=KSVmmZhoGyeY98kpkZ60Zynu2Sw7kejfRBk4quEZbuzS0dl6di0EQuPPKIbEz3Ztet YzM+C5afUz3NCAn0I8hL/2pplIIZ3bDZ6b4p+uSlNDHom50acmjsFI5KvO09Ego9zEN1 2eavqkCYLsi9dD+3J0nDO6l6wYgYKmqXkXfia3/frjIx/e2U7ZNbCKKxhoR+9BXTHedz eUYgQpLB+FvGHtvU2eTJzrWXeLEysmyGlKJzyOlSzSJz6DJDFaqGCb1OX2Fd5FP5zXjc 6ZPFrtpJOcc/tiJ8tg0qF/ym7cCwqkdNo8Z1JAGO1b9o5pRy+IvUM6Pi92p/Bq9zsTx3 d0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=hrAmJx63; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2-v6si14115861pge.74.2018.07.25.09.53.55; Wed, 25 Jul 2018 09:54:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=hrAmJx63; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729216AbeGYSFh (ORCPT + 99 others); Wed, 25 Jul 2018 14:05:37 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:52620 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728763AbeGYSFg (ORCPT ); Wed, 25 Jul 2018 14:05:36 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6PGo1mC044849; Wed, 25 Jul 2018 16:52:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=IImg7MCjyzTAi+iW6O//WdJRY8vIIYXkbE6/HHewhjc=; b=hrAmJx634AXM94UavmprkXrSGwQoJzHjHnGSgM+gY41t2IJ6wNxqTogL7LLs1sYjxB44 wNVtvsuh5SvCu2oyJJPbEXaMoR2cHLBML0Gxk3b5KYaouz19LBFa3mixQoI8s3xExAke SLyXBGQJJdvKU+ewjUOIPeiYdRfCTpmhJG3N9X8HmyR6VgzHpcpVqxLmtIaliG73/GT7 h7WYocP5rorMJ4sNyq21KGA/dlnVXUIsU2DPLpOF7AXzR/Kwo+tWBCZa+4T3cH2tiKr9 n1FN0Ld48ODybtJWieQRx6ISPi6mzHCs1FxHVca4E6nVQBK1CpoeCn06uXi/A7EHdiwj Jw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2kbv8t6bh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jul 2018 16:52:51 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6PGqo4s011442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jul 2018 16:52:50 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w6PGqnEA014057; Wed, 25 Jul 2018 16:52:49 GMT Received: from [10.209.243.127] (/10.209.243.127) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Jul 2018 09:52:48 -0700 Subject: Re: [PATCH] rds: send: Fix dead code in rds_sendmsg To: "Gustavo A. R. Silva" , Ka-Cheong Poon , "David S. Miller" Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <20180725152227.GA26303@embeddedor.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <088b745e-4f59-4283-16c1-755f46890990@oracle.com> Date: Wed, 25 Jul 2018 09:52:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180725152227.GA26303@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8964 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=927 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807250179 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/2018 8:22 AM, Gustavo A. R. Silva wrote: > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva > --- Looks fine. Acked-by: Santosh Shilimkar