Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1200256imm; Wed, 25 Jul 2018 13:24:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfPzpvMFANXInfJqJsMm9Zmh9Eq/tVvFaLGkSneCESkpegYrsVBz3/PByNMlRxXs6zpSxbq X-Received: by 2002:a63:ba43:: with SMTP id l3-v6mr21150963pgu.295.1532550260675; Wed, 25 Jul 2018 13:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532550260; cv=none; d=google.com; s=arc-20160816; b=Cy5MLEGlJZcDFNchYmgw8wdZ/jKSLYKibItEO6OhtGjfgatKFpTytq7tm05zUQimve PqQKx9zAx4PQPNKp2C/dVfXESwGPPQ3mwH0IwJdUBzVQcT3YbLYqw8QCgrG+jK3I0eF/ XeVo7DlzxEE8JZ+8OnjSO4PRkliEpOmLGx/F1TUl+ApZXlSbAQHw/uy3zPsIa/BJrvlY shvD+cQwpj764/pgX8+Vc+hS20zFtKP0mleq1uT/ufEfPyy3KMCC7OXO0GvWNX+/BIu/ bfIKL1nLOQKQhLVSpks2yn+IiWth175YFPNx4WdMOxCpfAym8I+/MtsHu366j3HM4tvY px8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=nAABX7W6PQGGU6ZsqFpQQ8x5ujIgnZZlTVmnLpKI244=; b=hxbeBvqc96+DITcDokINB5cdhr3nvHkmGI7MgJVvsPren0iCNMiRtWyYTCAjhfU5A6 vLAAJuLMjyA7xj5KAoxCaKFmBfe0+QnoupJzMhEMVPWCIOmkbYIHLJI2/cgGyPLt5xEM 6qnM+uae64KG7PzRFFEqCTcNgKyTlOh9HtIaSmXbh9JdIFjzZxFBF2oh0M4RbCmiXkz5 XwX61cESUjSGS6fLsZsE7OdMq59jW5Xi8YQ41mkv/gjZ0xNII4f2nqJrwK0V01C8IJ1m i9IFU3B+uFtUjamkrYOa3UaqekuDaRUNBQvCgzQV9RwIP5BXcRGNIvXMBVTAXBMUMHEs /bow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b="OyI/Csku"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22-v6si15087365pgk.534.2018.07.25.13.24.03; Wed, 25 Jul 2018 13:24:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b="OyI/Csku"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730857AbeGYVgZ (ORCPT + 99 others); Wed, 25 Jul 2018 17:36:25 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34408 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730536AbeGYVgY (ORCPT ); Wed, 25 Jul 2018 17:36:24 -0400 Received: by mail-pg1-f193.google.com with SMTP id y5-v6so6026021pgv.1 for ; Wed, 25 Jul 2018 13:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nAABX7W6PQGGU6ZsqFpQQ8x5ujIgnZZlTVmnLpKI244=; b=OyI/CskuF9BCWXcsrVrJgX5+XInuoEEF4rINIkXYfVZCIOCmThGsnvFiwjyrC1f+4E zY17jBuK45s5URzJIxskmQ3hh+fAh/ClZSJXv49MbrdoWNDf7PFYvsgJOWZiW36iIpIu Nztj2yAL9fhH/6MmePrMB/bNgf+bLzvMaV4Ng5Go7orPZL39XlIU7990U0l5aO5ZZnAY NqaAgG+Qxqo65j7hnCC3Zww0pznnAwhTrjzXYy3lt1xfOm3G2AmOIpDjRRrkp+iatSKu IzUuw0346mdB8XZAQ5iwxcpgxIQ3lMk9pVD9CXQdqi4D/UGBmzuAu1ETvMIa3xkm4iPz p1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nAABX7W6PQGGU6ZsqFpQQ8x5ujIgnZZlTVmnLpKI244=; b=j1N8QNA7v3Lt+kUvK3ACqprA8Gnd52kT8ZAtppd22RQ37NC6SBBucEsaiRbdcBt0Nf npuzTbz9Cy0WEd3YyoIUJtL7xgYDgDgmDM26DUy1VcchtqB6Yf09qrqHc6aj6Y6hIEZD 356nqz/lBuvxJNEU3yPNu4ETj8HB3QtYcrwHBjalOMMAq8JMxH0UvyFkLp50NThjQx9s e2ze456W+NX031EPjIaXglgIH2j1TvFweiL+anyD+4+Io0syspcMjdmJhp5NGzbosG0k sWZYhrp6lFPtVKgbTFgmuZfn4f7CG6YOHthBc4HIjIoTwkibpLMhZElZUYGYKsmhV/CE MkeA== X-Gm-Message-State: AOUpUlFJOBPwSc4fYp3TToK/UO7b0x/Y60mR/hByU42ZG8XC2L9LSZ+/ 2JgJ32vCYXPfB1JiRtTYYLWuh8tf/m8= X-Received: by 2002:a63:6849:: with SMTP id d70-v6mr21332490pgc.7.1532550187347; Wed, 25 Jul 2018 13:23:07 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:0:1000:1611:8fc3:703d:7635:5997]) by smtp.gmail.com with ESMTPSA id q25-v6sm31155574pfk.96.2018.07.25.13.23.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 13:23:06 -0700 (PDT) From: Mark Salyzyn To: linux-kernel@vger.kernel.org Cc: Nick Desaulniers , Mark Salyzyn , Steven Rostedt , Ingo Molnar , kernel-team@android.com, stable@vger.kernel.org Subject: [PATCH] tracing: do not leak kernel addresses Date: Wed, 25 Jul 2018 13:22:36 -0700 Message-Id: <20180725202238.165314-1-salyzyn@android.com> X-Mailer: git-send-email 2.18.0.233.g985f88cf7e-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Desaulniers Switch from 0x%lx to 0x%pK to print the kernel addresses. Fixes: CVE-2017-0630 Signed-off-by: Mark Salyzyn Cc: Nick Desaulniers Cc: Steven Rostedt Cc: Ingo Molnar Cc: Cc: # 3.18, 4.4, 4.9, 4.14 Cc: --- kernel/trace/trace_printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_printk.c b/kernel/trace/trace_printk.c index ad1d6164e946..93698023baf1 100644 --- a/kernel/trace/trace_printk.c +++ b/kernel/trace/trace_printk.c @@ -304,7 +304,7 @@ static int t_show(struct seq_file *m, void *v) if (!*fmt) return 0; - seq_printf(m, "0x%lx : \"", *(unsigned long *)fmt); + seq_printf(m, "0x%pK : \"", *(unsigned long *)fmt); /* * Tabs and new lines need to be converted. -- 2.18.0.233.g985f88cf7e-goog