Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1238843imm; Wed, 25 Jul 2018 14:13:50 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfngHh0GIwspp1tN8kQLWvrfN5TO9B7Y+3OZQ7hlEwjy69IQDCvUxCouQVGMMsEWZfp4D/j X-Received: by 2002:aa7:8645:: with SMTP id a5-v6mr23484994pfo.247.1532553230633; Wed, 25 Jul 2018 14:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532553230; cv=none; d=google.com; s=arc-20160816; b=Ls4zbJM69XmEyKWXb/O2qV2xtPSL6TF+HT9cjReWYYbuRMBs08OB+/34YOgxM1zU3v VSIpg5AAbUtF9kLy4xHDhfTFXejYVBmf3ugMYLEP0hMlvuTqVMYnjxzj3f9AmHcrUiuY L8YYfveWWB0chliZTr4GI1gI3Ouv2LQ8HOFREQqiuRckpPoclZMmoeJs/3hA4NVVAELE a3KCZ/yohh4U93PNcoUib3dbJWZHX/oS47x9FEOMmDpW0ZkZdO4r517Wuca1MnVBxr33 xLA5qtwkQKC0XUoe96uQnjfFdE8onitRM6+vPN6VIOaGd8BA7DaPt7tsH5ffKs5BdXPQ ON0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=EvtKLyoH2FarPprXLEfVhnOBTxpzuKsv/8isMNY8Whg=; b=wXXyhldOYZw5INxJ4nTfp69iwagdF4rcx6Zexb2sn/r/DKaY8AIOgpNBqET9jZZbuS xrUOkfGl9R6GZjR55vDmhYi16NSAs0IM/HU+n86wFCxoj2gHZik28Cfv8rrt1tesuVgS tz+/AkHRawv6vQgGOcBdcJPJRAqVYZOSdpI/lPcsL23Vcpa2WhjiIjFcgbFNbJo4JT1X WIqvubbDEXmoUDo/pJZu3+WDj6fm4c0eWQ0D1PV2X1thz3I+DDRUMCGmIDvz77VKWQvD Z9Uejn9GCcL5IBwbO+RNWRk/ButzKswbr0MPb9ueX2PjWBrWM/ZcLoz9DeOwAII28ZXD ubYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20-v6si14096881pgb.92.2018.07.25.14.13.35; Wed, 25 Jul 2018 14:13:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731401AbeGYWZ6 (ORCPT + 99 others); Wed, 25 Jul 2018 18:25:58 -0400 Received: from mga11.intel.com ([192.55.52.93]:47404 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731316AbeGYWZ5 (ORCPT ); Wed, 25 Jul 2018 18:25:57 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 14:12:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,402,1526367600"; d="scan'208";a="75929544" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by orsmga001.jf.intel.com with ESMTP; 25 Jul 2018 14:12:26 -0700 Date: Wed, 25 Jul 2018 15:12:26 -0600 From: Ross Zwisler To: Matthew Wilcox Cc: Ross Zwisler , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v14 00/74] Convert page cache to XArray Message-ID: <20180725211226.GA12326@linux.intel.com> Mail-Followup-To: Ross Zwisler , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net References: <20180617020052.4759-1-willy@infradead.org> <20180619031257.GA12527@linux.intel.com> <20180619092230.GA1438@bombadil.infradead.org> <20180619164037.GA6679@linux.intel.com> <20180619171638.GE1438@bombadil.infradead.org> <20180627110529.GA19606@bombadil.infradead.org> <20180627194438.GA20774@linux.intel.com> <20180725210323.GB1366@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725210323.GB1366@bombadil.infradead.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 02:03:23PM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > > > I think I see a bug. No idea if it's the one you're hitting ;-) > > > > > > > > I had been intending to not use the 'entry' to decide whether we were > > > > waiting on a 2MB or 4kB page, but rather the xas. I shelved that idea, > > > > but not before dropping the DAX_PMD flag being passed from the PMD > > > > pagefault caller. So if I put that back ... > > > > > > Did you get a chance to test this? > > > > With this patch it doesn't deadlock, but the test dies with a SIGBUS and we > > hit a WARN_ON in the DAX code: > > > > WARNING: CPU: 5 PID: 1678 at fs/dax.c:226 get_unlocked_entry+0xf7/0x120 > > > > I don't have a lot of time this week to debug further. The quickest path to > > victory is probably for you to get this reproducing in your test setup. Does > > XFS + DAX + generic/340 pass for you? > > I now have generic/340 passing. I've pushed a new version to > git://git.infradead.org/users/willy/linux-dax.git xarray Thanks, I'll throw it in my test setup.