Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1352151imm; Wed, 25 Jul 2018 16:44:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc+vXHCtjhRQorvmzOAKY/fqXxBcG47HmHOq8D4rkmE5BUjqoReg96I8K/glTWy96PBYN5O X-Received: by 2002:a17:902:27a8:: with SMTP id d37-v6mr15481050plb.290.1532562245708; Wed, 25 Jul 2018 16:44:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532562245; cv=none; d=google.com; s=arc-20160816; b=OcDzZj6H618ePXAdA15Yirm4bJ8FEYZ7mToIo150ZRfXpgRyZ3IJaFEMWeCRjI8LXH IvZHXcwHGMA69tJvoEgtpzTES8nV/v+iVXBKzXNKxtUYZ/+IKROdLj+Xl8/iuJS56ZT9 qhXm0sYVGX9gt/ryq9Qcn4VBaF0pSKnBQc29RUcpYFpQsipEYgoZLrdDrI2kyW8F9XuR mnbx11nBFCBUCEdVtZJIYE+AuB4lpvJUDf/ajzAdiUtTNyONtQkS8Z2ObfdB+n+FDYFn Z1yMeYyuzeK/Xske7ghm9FUOVCvlT681SenmETIBwR54Ms7qTVhTISqAp5pXVr0AD0RJ aSxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature:arc-authentication-results; bh=MYv04Y4NMeYu1yKZrcASn+OisjRlbQL3blm+f4995rM=; b=XS4yNCK+krzNYFErVyyuLiSSSPrSMrjjDd9Gk6csPIjbV+QyDz4CytreBG2GishRJZ q16uMcijNs2FFw4vcrA/DwNe/rGIUvEsKTjlm1QnaahdYAR8Z7m1opWK1FFOEx6e5hjD f/MhWNctji2SBHAAbHxki7T3xPPJa/emkWt+J3G6+mR+qAzFQDDCPNFrWLyMTo6KJfOL 4as3R1rUpvXWOx0ex9XpCNw0/A4NI5nFW4elutQBr1CmQ0OpaTFPZGSawyYmVcynSwyw F1ArXClV8OrlLRRfAtsEhScAhiD9jW7YhsddMrKMc2fx7HVvarMQO4jE1wuJFsarCi8e v5mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wF5Nr81j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3-v6si13769567pgp.220.2018.07.25.16.43.50; Wed, 25 Jul 2018 16:44:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wF5Nr81j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731773AbeGZAiw (ORCPT + 99 others); Wed, 25 Jul 2018 20:38:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:57316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731737AbeGZAiw (ORCPT ); Wed, 25 Jul 2018 20:38:52 -0400 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B888F20833; Wed, 25 Jul 2018 23:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532561095; bh=uvZ7fZHbqsWGhawbu10rs+Q1Cz7f0vMIT1wTfTdEbxg=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=wF5Nr81jR00ojVQoIJaiW9PQPVWnvWlIkYkKGEmPN+vWH2toYSMm5zxejii3O2NKP agfsVv5H2bAbVIkgWwkRxVAeNKv9B6rqNebez4W3YxsCVJodBgk8pibDeMmo3VZttW LZoQCK4xLSfuztNwV8NvMTuRo/2Kwj1HvgGpGlAY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Marcel Ziswiler , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org From: Stephen Boyd In-Reply-To: <20180720075422.26563-1-marcel@ziswiler.com> Cc: Marcel Ziswiler , Thierry Reding , Prashant Gaikwad , Peter De Schrijver , Jonathan Hunter , Michael Turquette , linux-clk@vger.kernel.org References: <20180720075422.26563-1-marcel@ziswiler.com> Message-ID: <153256109511.48062.12389268791907553857@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH] clk: tegra: probe deferral error reporting Date: Wed, 25 Jul 2018 16:24:55 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marcel Ziswiler (2018-07-20 00:54:22) > From: Marcel Ziswiler > = > Actually report the error code from devm_regulator_get() which may as > well just be a probe deferral. > = > Signed-off-by: Marcel Ziswiler > = > --- > = > drivers/clk/tegra/clk-dfll.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > = > diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c > index 48ee43734e05..b2123084e175 100644 > --- a/drivers/clk/tegra/clk-dfll.c > +++ b/drivers/clk/tegra/clk-dfll.c > @@ -1609,8 +1609,9 @@ int tegra_dfll_register(struct platform_device *pde= v, > = > td->vdd_reg =3D devm_regulator_get(td->dev, "vdd-cpu"); > if (IS_ERR(td->vdd_reg)) { > - dev_err(td->dev, "couldn't get vdd_cpu regulator\n"); > - return PTR_ERR(td->vdd_reg); > + ret =3D PTR_ERR(td->vdd_reg); > + dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n", = ret); Do you want to know that a probe defer is happening? Usually patches are sent to make that error path silent.