Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] clk: tegra: probe deferral error reporting
To:     Stephen Boyd <sboyd@kernel.org>,
        Marcel Ziswiler <marcel@ziswiler.com>,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org
References: <20180720075422.26563-1-marcel@ziswiler.com>
 <153256109511.48062.12389268791907553857@swboyd.mtv.corp.google.com>
From:   Peter Geis <pgwipeout@gmail.com>
Message-ID: <b202fe11-108f-c62c-bb6d-9e3a7de5a964@gmail.com>
Date:   Wed, 25 Jul 2018 19:42:34 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <153256109511.48062.12389268791907553857@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/25/2018 7:24 PM, Stephen Boyd wrote:
> Quoting Marcel Ziswiler (2018-07-20 00:54:22)
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> Actually report the error code from devm_regulator_get() which may as
>> well just be a probe deferral.
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> ---
>>
>>   drivers/clk/tegra/clk-dfll.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
>> index 48ee43734e05..b2123084e175 100644
>> --- a/drivers/clk/tegra/clk-dfll.c
>> +++ b/drivers/clk/tegra/clk-dfll.c
>> @@ -1609,8 +1609,9 @@ int tegra_dfll_register(struct platform_device *pdev,
>>   
>>          td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
>>          if (IS_ERR(td->vdd_reg)) {
>> -               dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
>> -               return PTR_ERR(td->vdd_reg);
>> +               ret = PTR_ERR(td->vdd_reg);
>> +               dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n", ret);
> 
> Do you want to know that a probe defer is happening? Usually patches are
> sent to make that error path silent.
> 

Just asking as the newbie here, but shouldn't probe deferral be 
regulated to dev_debug?
Then pass any other error code as dev_err.