Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 25 Jul 2018 17:40:45 -0700
From:   pheragu@codeaurora.org
To:     Joe Perches <joe@perches.com>
Cc:     Apw <apw@canonical.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Bryanh <bryanh@codeaurora.org>, Ckadabi <ckadabi@codeaurora.org>,
        Tsoni <tsoni@codeaurora.org>
Subject: Re: Reminder to review a few patches sent two weeks ago
In-Reply-To: <612de3c34f4986ac3ee6040af200a0e179acdcbd.camel@perches.com>
References: <e531d3a7a9db2e8d06da01cab2ad090d@codeaurora.org>
 <612de3c34f4986ac3ee6040af200a0e179acdcbd.camel@perches.com>
Message-ID: <2263042da44fae7cae949ac383c41964@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018-07-24 17:33, Joe Perches wrote:
> On Tue, 2018-07-24 at 14:56 -0700, pheragu@codeaurora.org wrote:
>> A reminder to review a few patches I had sent last week. Below are the
>> links for the patches.
>> 
>> https://lkml.org/lkml/2018/7/5/798
> 
> I have no fundamental object to this one, but
> the 80 column use is unnecessary and should be
> coalesced before it can be applied.
> 
> Perhaps:
> 
> # warn about #if 1
> 		if ($line =~ /^.\s*\#\s*if\s+1\b/) {
> 			WARN("IF_1",
> 			     "Consider removing the #if 1 and its #endif\n" .  $herecurr);
>  		}
> 
>> http://lists-archives.com/linux-kernel/29168320-checkpatch-check-for-invalid-return-codes.html
> 
> This one has I think too many existing uses of
> things like "return -1;"
> 
> $ git grep -P "return\s*\-\d+\s*;" | wc -l
> 9929
> 
> How many of these are actually appropriate?
> 
I did go through a few of the files which return -1 in their functions,
I observed that most of them were inappropriate and there was a case
where actually the use of return -1 was 
incorrect(kernel/arch/ia64/mm/contig.c
in the function find_bootmap_location()). We could actually catch such 
errors
from now on if we use this patch.

> Also, no space is required between return and -1
> by c90 and this should use $Int so it should be:
> 
> 	if ($line =~ /\breturn\s*\-\$Int\s*;/) {
> 
> etc...