Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Jul 2018 21:22:58 -0700 (PDT)
Message-Id: <20180725.212258.182134114222639499.davem@davemloft.net>
To:     dima@arista.com
Cc:     linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
        steffen.klassert@secunet.com, 0x7f454c46@gmail.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH 06/18] netlink: Do not subscribe to non-existent groups
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180726023144.31066-7-dima@arista.com>
References: <20180726023144.31066-1-dima@arista.com>
        <20180726023144.31066-7-dima@arista.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Dmitry Safonov <dima@arista.com>
Date: Thu, 26 Jul 2018 03:31:32 +0100

> Make ABI more strict about subscribing to group > ngroups.
> Code doesn't check for that and it looks bogus.
> (one can subscribe to non-existing group)
> Still, it's possible to bind() to all possible groups with (-1)
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Dmitry Safonov <dima@arista.com>

This really has nothing to do with adding a compat layer for xfrm,
and is a bug fix that should be submitted separately in it's own
right.