Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp62068imm; Wed, 25 Jul 2018 22:39:26 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeCq+K3ZVqDRa+uTnd+RF9MMrpsNuzXkSx0nbWVBVaXx1TRa12gxdpT/Elk8RDigABFZwMN X-Received: by 2002:a65:64c8:: with SMTP id t8-v6mr592474pgv.110.1532583566834; Wed, 25 Jul 2018 22:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532583566; cv=none; d=google.com; s=arc-20160816; b=AmsSuapGRwAQNY3C1JZcrVIJ4Z582ltNovtLcIJj2mOvF2rxZfm0KTNCA4MwlQg/x8 YUY6oJwiHGt9z4mdNPh33m2pHBcGxPfIjht27femj6TVh9TBjal4hL2sQQGRLC6DirCW eKdKgO+xBdjPzcMzoQBovObRQkcHm58uPtYsIS1hW1AuDJ8xWKIyEsD9A8mxwHwYuEDI H5wsDLoPE+yu7EBVECfRDqHnmxhHb3PxAhYrUuKqiOxeFBNBUs/T3DPcF6KT2Qnx9/85 xEjYoloZVEyyFIeyo7YDEAI6UQRnc8sP8k9M+zq2duIZ68Xl0OJiq0zZTMU03+wS0iVG 35dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=mC21bQoJm6qKC85XbnmPDjJZLlJZEYnE0fxe5GPQ1u0=; b=tUDNC8ze0/fvsRGGw/GAVGRI676X+bclFocjwmGydWW7PHa1Wpeylufg4orvQCH29N da7Edm6758ftKWE9JzoWdJ0KtL1jRU9ZOPwToWX0qfth5VKRiT4hJCIpiBHtTDs1odvW 5pdk3yphPL1LdB0FrC4T+3Uosr9F5S0948hUVrQ0fX3lvOAUROFWhIxQGYsq3k6q5dMs frosNpsyKiX5/W/fzggGu3t54iQRHnErKeBljaprXloW6QVCLSIvwSsgyiPHGUffM5UT qTxvNHHvOuasudaxRJl/WT0iRe9inzQJCwEvxVSbiHtONnFPgfurNSnVx7TxpdKaam82 3cLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g185-v6si472320pgc.151.2018.07.25.22.39.12; Wed, 25 Jul 2018 22:39:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbeGZGxa (ORCPT + 99 others); Thu, 26 Jul 2018 02:53:30 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33284 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728727AbeGZGxa (ORCPT ); Thu, 26 Jul 2018 02:53:30 -0400 Received: from localhost (unknown [172.58.43.249]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7247112DE580C; Wed, 25 Jul 2018 22:38:22 -0700 (PDT) Date: Wed, 25 Jul 2018 22:38:21 -0700 (PDT) Message-Id: <20180725.223821.2249486672657415594.davem@davemloft.net> To: gustavo@embeddedor.com Cc: ka-cheong.poon@oracle.com, santosh.shilimkar@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rds: send: Fix dead code in rds_sendmsg From: David Miller In-Reply-To: <20180725152227.GA26303@embeddedor.com> References: <20180725152227.GA26303@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jul 2018 22:38:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Wed, 25 Jul 2018 10:22:27 -0500 > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva Applied.