Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp64500imm; Wed, 25 Jul 2018 22:43:02 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfNToubTx/r+cADsv8noawr3tGuIrG3QQfBS1zi3lfiL4BnIbXaUsIM3a0jXtmrO5BpDspT X-Received: by 2002:a17:902:9f90:: with SMTP id g16-v6mr602786plq.304.1532583782377; Wed, 25 Jul 2018 22:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532583782; cv=none; d=google.com; s=arc-20160816; b=HXlLuKf1shd1/E+rhBRETNACb14HbN3YVEzoQq9Xtr/nHxjoAD98bkiypc941DXUzm CYnomK5WUQvZ2MOgZSpS9lIxsR1UnWgJunC6nOOKAdaSiVbkggznap9tSgf2sTOHdovc nJZ8QkTn5sGttUHzegB2I1cnUC8nEb8xvs7LqLG2XVq75Nv/KY0M+N7Pb2Ag46xR1ORI IKmDMWGJfTfqv2OfvtsnBmdS13T/EIgYymYanaM/JODD5a3rw/xXNXKwGc5ZWZ0aPsh8 7vJwmoPeMO+KJZhfJAH8o0PGEoIruHqLMn0xmj3oWkXhfF73l4NjYWiaLhfZc+teFXpR t9qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=d/d2b0JdkE3eepkY5bqvUrt7grXtkIZ/P+mQvPdhJ4M=; b=atSffogw+p5gvSqJLDknHb6MsiS3djwuMmegaONi+44ECS5KszYFdFXET3wpD8G4hp tbXz1JxnI1tCl/pmiypkKVRtYC85dhyuujz1X0wD2Lsk3O5+Rdqubs3VM703hs2MlpD9 DQP2Wx2ZN5A7LCsi1o/LG3g+LJhzyjGZUYmfmDyhG5sVafAX/mjhjgnfonAyyWZ6687X mbbDOhL+MefeNV/WJVpW2J6phmCRGghgPJzwKxaXRchapHwDLwsZ2Vl/M45ILBXKwogG MLsSxAyo5j0E3s/Ech7gL1GSOW1185N7AqrEx8zR9we4xmGRpCwXzybum+qsZ0W2H16D FNuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q68-v6si523889pfl.317.2018.07.25.22.42.46; Wed, 25 Jul 2018 22:43:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728974AbeGZG41 (ORCPT + 99 others); Thu, 26 Jul 2018 02:56:27 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:50755 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727070AbeGZG41 (ORCPT ); Thu, 26 Jul 2018 02:56:27 -0400 X-Originating-IP: 79.86.19.127 Received: from [192.168.0.11] (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 49C9B40005; Thu, 26 Jul 2018 05:41:03 +0000 (UTC) Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives To: Michael Ellerman , Michal Hocko Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Naoya Horiguchi , Mike Kravetz References: <20180705110716.3919-1-alex@ghiti.fr> <20180709141621.GD22297@dhcp22.suse.cz> <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> <87d0vehx16.fsf@concordia.ellerman.id.au> From: Alex Ghiti Message-ID: <67aba0f0-c0d4-b06f-5fbc-f4d113ce5033@ghiti.fr> Date: Thu, 26 Jul 2018 05:41:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87d0vehx16.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr X-Spam-Level: * Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everyone, This is the result of the build for all arches tackled in this series rebased on 4.18-rc6: arm: ??????? versatile_defconfig: without huge page OK ??????? keystone_defconfig: with huge page OK arm64: ??????? defconfig: with huge page OK ia64: ??????? generic_defconfig: with huge page OK mips: ??????? Paul Burton tested cavium octeon with huge page OK parisc: ??????? generic-64bit_defconfig: with huge page does not link ??????? generic-64bit_defconfig: without huge page does not link ??????? BUT not because of this series, any feedback welcome. powerpc: ??????? ppc64_defconfig: without huge page OK ??????? ppc64_defconfig: with huge page OK sh: ??????? dreamcast_defconfig: with huge page OK sparc: ??????? sparc32_defconfig: without huge page OK sparc64: ??????? sparc64_defconfig: with huge page OK x86: ??????? with huge page OK Alex On 07/23/2018 02:00 PM, Michael Ellerman wrote: > Alex Ghiti writes: > >> Does anyone have any suggestion about those patches ? > Cross compiling it for some non-x86 arches would be a good start :) > > There are cross compilers available here: > > https://mirrors.edge.kernel.org/pub/tools/crosstool/ > > > cheers > >> On 07/09/2018 02:16 PM, Michal Hocko wrote: >>> [CC hugetlb guys - http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr] >>> >>> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote: >>>> In order to reduce copy/paste of functions across architectures and then >>>> make riscv hugetlb port (and future ports) simpler and smaller, this >>>> patchset intends to factorize the numerous hugetlb primitives that are >>>> defined across all the architectures. >>>> >>>> Except for prepare_hugepage_range, this patchset moves the versions that >>>> are just pass-through to standard pte primitives into >>>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be >>>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***. >>>> >>>> s390 architecture has not been tackled in this serie since it does not >>>> use asm-generic/hugetlb.h at all. >>>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect). >>>> >>>> This patchset has been compiled on x86 only. >>>> >>>> Changelog: >>>> >>>> v4: >>>> Fix powerpc build error due to misplacing of #include >>>> outside of #ifdef CONFIG_HUGETLB_PAGE, as >>>> pointed by Christophe Leroy. >>>> >>>> v1, v2, v3: >>>> Same version, just problems with email provider and misuse of >>>> --batch-size option of git send-email >>>> >>>> Alexandre Ghiti (11): >>>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h >>>> hugetlb: Introduce generic version of hugetlb_free_pgd_range >>>> hugetlb: Introduce generic version of set_huge_pte_at >>>> hugetlb: Introduce generic version of huge_ptep_get_and_clear >>>> hugetlb: Introduce generic version of huge_ptep_clear_flush >>>> hugetlb: Introduce generic version of huge_pte_none >>>> hugetlb: Introduce generic version of huge_pte_wrprotect >>>> hugetlb: Introduce generic version of prepare_hugepage_range >>>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect >>>> hugetlb: Introduce generic version of huge_ptep_set_access_flags >>>> hugetlb: Introduce generic version of huge_ptep_get >>>> >>>> arch/arm/include/asm/hugetlb-3level.h | 32 +--------- >>>> arch/arm/include/asm/hugetlb.h | 33 +---------- >>>> arch/arm64/include/asm/hugetlb.h | 39 +++--------- >>>> arch/ia64/include/asm/hugetlb.h | 47 ++------------- >>>> arch/mips/include/asm/hugetlb.h | 40 +++---------- >>>> arch/parisc/include/asm/hugetlb.h | 33 +++-------- >>>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 + >>>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 + >>>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------ >>>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 + >>>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 + >>>> arch/sh/include/asm/hugetlb.h | 54 ++--------------- >>>> arch/sparc/include/asm/hugetlb.h | 40 +++---------- >>>> arch/x86/include/asm/hugetlb.h | 72 +---------------------- >>>> include/asm-generic/hugetlb.h | 88 +++++++++++++++++++++++++++- >>>> 15 files changed, 143 insertions(+), 384 deletions(-) >>>> >>>> -- >>>> 2.16.2