Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Jul 2018 08:11:15 +0200
From:   Michal Hocko <mhocko@kernel.org>
To:     Jiang Biao <jiang.biao2@zte.com.cn>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org,
        hillf.zj@alibaba-inc.com, minchan@kernel.org, ying.huang@intel.com,
        mgorman@techsingularity.net, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn
Subject: Re: [PATCH] mm/vmscan: fix page_freeze_refs in comment.
Message-ID: <20180726061115.GR28386@dhcp22.suse.cz>
References: <1532561657-98783-1-git-send-email-jiang.biao2@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1532561657-98783-1-git-send-email-jiang.biao2@zte.com.cn>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu 26-07-18 07:34:17, Jiang Biao wrote:
> page_freeze_refs has already been relplaced by page_ref_freeze, but
> it is not modified in the comment.

Hmm
$ git grep page_refs_freeze origin/master
$

The same is the case in the linux-next tree. Which tree are you looking at?

> 
> Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 03822f8..d29e207 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -744,7 +744,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
>  		refcount = 2;
>  	if (!page_ref_freeze(page, refcount))
>  		goto cannot_free;
> -	/* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */
> +	/* note: atomic_cmpxchg in page_refs_freeze provides the smp_rmb */
>  	if (unlikely(PageDirty(page))) {
>  		page_ref_unfreeze(page, refcount);
>  		goto cannot_free;
> -- 
> 2.7.4
> 

-- 
Michal Hocko
SUSE Labs