Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp183478imm; Thu, 26 Jul 2018 01:27:42 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeLWHcOcB3UcQgQPGS6k/TEENpYDOcPa4W9DZ46DaN1lxXGQb2YqRQ0qoJsBTC3U9il7+qJ X-Received: by 2002:a62:90d4:: with SMTP id q81-v6mr1138115pfk.37.1532593662546; Thu, 26 Jul 2018 01:27:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532593662; cv=none; d=google.com; s=arc-20160816; b=yug1ktbVGSBK78l7GhT/+wau2zo0NQH3mYJ9vjkbzi7NAU/13qtt/TI8oZUBl4lYcw nA2WCTBgq3rULepLFu04QIalYzL1PGoBdmhP/stFhyZH+G31GUMIywv/ZyJzzjHy5ngA YaxEUcMlunBMm20u3414iocP07eDX6KtiT0noSnPZPXxDfuiUE/F0zd0sF7tDJsMP2wv Lvl54Uks/plm9tZrevasDK3cNsE+3oWxFYUqjtO/JIucdDRtouN0JDgYjhWDZ199Tl5X NGDkHERcBpmEO8iiBjg1gBCleb9T+8b2HQg59zJIUHzfiRcCYXuOE+Sfmm9NamfhcbSe Lnfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=VSZy8z8euMFvSmptFK3vq4c3at+VXqgjBzC8CFh3BNw=; b=mRtuGrN4+PVwz2Cv77vlGqpMBGKyY7IhCh4nW9NHShopam91Kc+OdVF55+PKL7T29C IkBHyajkn36qO8EwgzAgxPqYXxv4DxVzO3zqAvP4mqmdIYUqZaE0FPaBecw6++NM8ICC Xysago7w55c5RtRtLtSHm5vFhnZNHaUnrMFETbKTXYZZV3Cc/CJECGI04Ou+Y9/LpaMv U5Md1XAAGa/1QygjYj9qmt79kGpspx4F1/45xJWlLdDcfA3GeclRIwW2rm4/hXZlGMZ7 j9RbDZFLHuq94GSnEo8l+oN7NCzZyDZZQXx5ZvP97zKPiru9M2AtECzPq8ZuZeC9XgXf yLyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@armlinux.org.uk header.s=pandora-2014 header.b="dhHI/l4z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v16-v6si772690pfm.341.2018.07.26.01.27.27; Thu, 26 Jul 2018 01:27:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@armlinux.org.uk header.s=pandora-2014 header.b="dhHI/l4z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729207AbeGZJmO (ORCPT + 99 others); Thu, 26 Jul 2018 05:42:14 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:53988 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbeGZJmO (ORCPT ); Thu, 26 Jul 2018 05:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AFX+MXs8zyhQa0Fta/QCyt2naUj5o5TK+Pk7DYHG57I=; b=dhHI/l4zEUn8AMnnW2oTn1BfG kJlP11ZpAyBshLHi0+m7InqmUkc+xmCDDDCMFws2kOsXmCqSJBO12PJrGNdI0dZ/frhKTxFlzN+N/ nh59yHhTEaPRSd95GmICv094o2tt5rOpOVQSk88dgk4yYaoXRxNu7eysqrlvTcMJIvOok=; Received: from n2100.armlinux.org.uk ([fd8f:7570:feb6:1:214:fdff:fe10:4f86]:50556) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1fibbO-0002my-58; Thu, 26 Jul 2018 09:26:26 +0100 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1fibbL-0007ja-Fn; Thu, 26 Jul 2018 09:26:23 +0100 Date: Thu, 26 Jul 2018 09:26:21 +0100 From: Russell King - ARM Linux To: bgoswami@codeaurora.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org Subject: Re: [PATCH][RESEND 2] component: enhance handling of devres group for master Message-ID: <20180726082621.GW17271@n2100.armlinux.org.uk> References: <1532585188-7831-1-git-send-email-bgoswami@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532585188-7831-1-git-send-email-bgoswami@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 11:06:28PM -0700, bgoswami@codeaurora.org wrote: > From: Banajit Goswami > > The devres group opened for a master is left open-ended (without > devres_group_close) even after bind() is complete. Similarly, while > releasing the devres resources for master, the most recently opened > devres group is selected, and released without identifying the > targeted group. As the devres group opened before master bind was > never closed, there may have unintended consequences of releasing > devres resources that were allocated after master bind() function > was complete. ... as intended, because this layers on top of the driver model. You are aware that the driver model leaves its implicit group open as well? I think you need to explain why you need this - what is the problem scenario that you are encountering. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up