Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Xidong Wang <wangxidong_97@163.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        Michal Nazarewicz <mina86@mina86.com>,
        Vincent Pelletier <plr.vincent@gmail.com>
Cc:     wangxidong_97@163.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb:gadget:function:fix memory leak
In-Reply-To: <1532344186-30505-1-git-send-email-wangxidong_97@163.com>
References: <1532344186-30505-1-git-send-email-wangxidong_97@163.com>
Date:   Thu, 26 Jul 2018 14:08:09 +0300
Message-ID: <87fu061ch2.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


hi,

Xidong Wang <wangxidong_97@163.com> writes:
> In function f_audio_set_alt(), the memory allocated by
> usb_ep_alloc_request() is not released on the error path
> that req->buf, which holds the return value of kzalloc(),
> is NULL. This will result in a memory leak bug.
>
> Signed-off-by: Xidong Wang <wangxidong_97@163.com>
> ---
>  drivers/usb/gadget/function/f_uac1_legacy.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/ga=
dget/function/f_uac1_legacy.c
> index 24c086b..2fcdade 100644
> --- a/drivers/usb/gadget/function/f_uac1_legacy.c
> +++ b/drivers/usb/gadget/function/f_uac1_legacy.c
> @@ -630,8 +630,11 @@ static int f_audio_set_alt(struct usb_function *f, u=
nsigned intf, unsigned alt)
>  							ERROR(cdev,
>  							"%s queue req: %d\n",
>  							out_ep->name, err);
> -					} else
> +					} else {
> +						usb_ep_free_request(
> +							out_ep, req);
>  						err =3D -ENOMEM;
> +					}

I feel like this hunk has been ping ponging between having
usb_ep_free_request() and not having it because completion callback will
call usb_ep_free_request() or something along those lines.

Can we get a final solution that solves all cases and doesn't introduce
other bugs?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAltZq5kACgkQzL64meEa
mQbMPQ/+JMoKRBXYMh8ZQdgYRUkYM47HJzhCxgg6cOkGTLLmv73INF7e3m38kK5C
bE9/LJLHzLZtuJs2mG2WbPHWEVQC1JXjTwm9frroz+XwNk1Jm1ZbN+d2Hio6TZQd
GA0mkoavUnfdO+MQipG394KNnb4qdbRgfyY/eGRJm+Pqf0OzFcXKR0wZSyEzWpmU
Zb18eRIr+TeD1R3O0JrXtrl2iGds7Ue9EdCVtj90Yu/Lsx/SMb+tmp8wL6235Vvs
I74quqH2YqU8KKxRZW0Mc5F7r1WNjxMOEjNN1OKL/LikdL0RzhaJE4lmqmezQBp2
xiOceBJPzGVqLB8X9svPVX02UZocimr92/fIB9FTjN/cmkg3IiyMz0GqNSODtufF
89iENMIk9bCuuxTOM/zERbvYDA0m0UEV/QhjZxVCSOn/BaRAf4IsIUEVyzUNhq0V
f6f7Yw4aLjXa0m+2HG5Bcu1rH18JH1WMgHi1ltLUYucnWXvM3W5sOztKXMhouDRm
wax2HMdMmVxQeawNES0+KTMBbwtntmmD8GgLSK7w4gg/ciQxWTC4c83N21taPP8Q
CWlKcXefuwT1HTErT83l6O/uhriNGjoym0xutO49F4ilBu/TtX/AR1xBkkVNagg6
lXxjKatFDpdsVXKfJOyNCro6kKxzqaBop45z6YpFbz3hLcUq4iE=
=DHiW
-----END PGP SIGNATURE-----
--=-=-=--