Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp451272imm; Thu, 26 Jul 2018 06:31:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpffGBOvvbHS+esp3QhhTlouk3DkOK5S1ywitnQq8CkEyeW1W+r4PsZQQDOyk/RaxZNeFepa X-Received: by 2002:a63:5964:: with SMTP id j36-v6mr2031371pgm.222.1532611895753; Thu, 26 Jul 2018 06:31:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532611895; cv=none; d=google.com; s=arc-20160816; b=uZkuaL7X5rNiMDRHK+vHZZiFZcVCoumCDS7zYcZNu9JROtrGNYlauh2FBzNuKZHhIh JyRAdtJYUO48Vx2iOegj6pMlaYjxbjd8YTXHNE95uS/V7sjE3zwKj/IgK6Mn1ULB2xZd FWHJwAHbtazlcJtzaBXQ1rqAbwim308Wnp5jg5b3FjuZOScKBybwweuSM0QcBO58pZ+t C+b/J6IJAcjLnKjls68UiU0/AEAc8dW5gEJZXMpHaiL+f4xEZHREve3DtN8eqFq7gNqn NHtjGL9H4uYz7suLR5UYG19OLO06ablyU0jmXnVilRYyEGXuQ6sg424qFe9vrK/LtOtF wB/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=DHPSRW0sf4DJlg4JkK+EnUCg+YfXWzUOE1zsfrYiRcc=; b=tKzcu22zhCh3F+lz0uVGv+mGf/Clz4sj31kZVwNy8PD8s2/RQWOY82tRcIpfEfk3Od nGBkjiRJVvrw/7mmDaZy78zvHIMOTjSGsrou0avg1IdLNcOVLr4oq4xDonYHou9JnW6c Bk8CAbjFvQu1xekIdBnLQEiAw4PMr7+uWhLpwMrhtR/Ol1GaYGN8CrcEhUzsqPGuf3gd nELgXx/mIKs3kXPA1gQH+fqzUIZkWR7CQljpxPZtAPvj3EDhdhs4NcTZS+Jd8RzSU9XJ sJGeNLZP2KfYGzvKB9+f0ozqgd2o4zaVJ9nGIAlkuG0tPQ/2hKVgHsrYkQcH0Sh5NONS C4pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FRnHqeTY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13-v6si1342051pgh.642.2018.07.26.06.31.21; Thu, 26 Jul 2018 06:31:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FRnHqeTY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730952AbeGZOrW (ORCPT + 99 others); Thu, 26 Jul 2018 10:47:22 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:52007 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730293AbeGZOrV (ORCPT ); Thu, 26 Jul 2018 10:47:21 -0400 Received: by mail-wm0-f67.google.com with SMTP id y2-v6so1998465wma.1 for ; Thu, 26 Jul 2018 06:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=DHPSRW0sf4DJlg4JkK+EnUCg+YfXWzUOE1zsfrYiRcc=; b=FRnHqeTYbpxO3c/h330jF1KKzQEhJL6ggAE6zE799ehLyLYTQqzbXLWscplmuicH0f HqZxvd+fCa56kQUJ5mzijKNzUZeF1cmWbkAuVreBiQtiVbiYj4Iy4QZ/6ulH7+/Fb+dE 7TG87be/ozyhd+4b0GvWvGVUkmooDWY20KxgdnELq3uSZnztoyQpr2oXNvvzhw0WOmLX Dj6ZnB1iV0SnxRpD6aFXYTEx4ncytGffmSyHN4cb6G5Ca8+JQ56hMYqR04UCi/8wnLi0 nGEcqS/lA84CStKhEabmdrVi2m/zT1oB3ctt1N/Be7LWacRLsg64CwtERFcrNEy9tDkU 2XJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=DHPSRW0sf4DJlg4JkK+EnUCg+YfXWzUOE1zsfrYiRcc=; b=dBhclXUKIaUsLOkE02ylJc/VF+0j2xPCNrW9KH6+w24iuYBQT6FM+pSVL9PburRNJv TXhSZWE5Gsd7MeV/mCx0HRhE7gEzEnLPTmUOLNgKcKWmTML+mpp/a2R/MN8bbexMVtXk PDfn2IdnKBrZeGFnOiMiWp80n6pvOS6LxeGRtpZ9nloaCFEc1kuGPZFxHhIPldWFAa6s VWzs2mZLflsaCnrTOI/714nuxlTMjmZva7kjeXn9Q0d2uRl0x4kolxc1MHXKGDLCu3WC 17PFkgEwmklcESj4IgEa/5M9dOMmr4Wok583c58yagZTLOtBRZBFRogbwBdqnBWB9qBo Jcyw== X-Gm-Message-State: AOUpUlELiFyeSAnDqBVRaVczG1ntKG9qql1tpj7tuiN5zfMuM4uDMhy2 VBx8mXZwgFeej+FCfn5Axeo= X-Received: by 2002:a1c:d6cf:: with SMTP id n198-v6mr1655273wmg.61.1532611827412; Thu, 26 Jul 2018 06:30:27 -0700 (PDT) Received: from we.local (ppp-2-87-92-87.home.otenet.gr. [2.87.92.87]) by smtp.gmail.com with ESMTPSA id j8-v6sm2126641wru.41.2018.07.26.06.30.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Jul 2018 06:30:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by we.local (Postfix) with ESMTP id 9214A6407E7; Thu, 26 Jul 2018 16:30:25 +0300 (EEST) X-Virus-Scanned: amavisd-new at local X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from we.local ([127.0.0.1]) by localhost (we.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uSpPi7S0SeF5; Thu, 26 Jul 2018 16:30:20 +0300 (EEST) Received: by we.local (Postfix, from userid 1000) id E7C536408C7; Thu, 26 Jul 2018 16:30:18 +0300 (EEST) From: Georgios Tsotsos To: Greg Kroah-Hartman Cc: Georgios Tsotsos , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] Staging: octeon-usb: Change coding style of CVMX_WAIT_FOR_FIELD32 marco. Date: Thu, 26 Jul 2018 16:30:08 +0300 Message-Id: <37553f45bfb34de4b0af476286b1b782ea834963.1532610629.git.tsotsos@gmail.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixing coding style for CVMX_WAIT_FOR_FIELD32 was confusing. Also encapsulates into parentheses timeout_usec. Signed-off-by: Georgios Tsotsos --- drivers/staging/octeon-usb/octeon-hcd.c | 44 +++++++++++++++++---------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index cff5e790b196..c8e0ebf1434f 100644 --- a/drivers/staging/octeon-usb/octeon-hcd.c +++ b/drivers/staging/octeon-usb/octeon-hcd.c @@ -378,27 +378,29 @@ struct octeon_hcd { }; /* This macro spins on a register waiting for it to reach a condition. */ -#define CVMX_WAIT_FOR_FIELD32(address, _union, cond, timeout_usec) \ - ({int result; \ - do { \ - u64 done = cvmx_get_cycle() + (u64)timeout_usec * \ - octeon_get_clock_rate() / 1000000; \ - union _union c; \ - \ - while (1) { \ - c.u32 = cvmx_usb_read_csr32(usb, address); \ - \ - if (cond) { \ - result = 0; \ - break; \ - } else if (cvmx_get_cycle() > done) { \ - result = -1; \ - break; \ - } else \ - __delay(100); \ - } \ - } while (0); \ - result; }) +#define CVMX_WAIT_FOR_FIELD32(address, _union, cond, timeout_usec) \ +({ \ + int result; \ + do { \ + u64 done = cvmx_get_cycle() + (u64)(timeout_usec) * \ + octeon_get_clock_rate() / 1000000; \ + union _union c; \ + \ + while (1) { \ + c.u32 = cvmx_usb_read_csr32(usb, address); \ + \ + if (cond) { \ + result = 0; \ + break; \ + } else if (cvmx_get_cycle() > done) { \ + result = -1; \ + break; \ + } else \ + __delay(100); \ + } \ + } while (0); \ + result; \ +}) /* * This macro logically sets a single field in a CSR. It does the sequence -- 2.16.4