Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp498295imm; Thu, 26 Jul 2018 07:15:46 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe1H1OXtCpEd0jNeaoyP0BkAoBzbplYR1suWaCuvSce+R9wkApJDn/zfIpa6U5TNBu3bN8j X-Received: by 2002:a63:9b19:: with SMTP id r25-v6mr2179855pgd.44.1532614546828; Thu, 26 Jul 2018 07:15:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532614546; cv=none; d=google.com; s=arc-20160816; b=uX2JM3L0n42EOZejqm3Y2xuB24hqAsVpAq3VrHhtr0HKiaTOc3ht8TswipzuzhnTa6 wtUDj9kCjdeFyJdjaRfpELZu+FmNRxLWwV4dTRXNVzWlA81DtUY09vE+nDPnYkI0FJp6 sAH6GTVxyocYr8P92P4jS3LCvu6lni6sRiqsYLor2kox9jE3J3vaPDVAODbnH8kVQr2M IHZVwdkBWk1AfAMFpHSbk+RflPsCch4IJPRyBLtbRHtYEFe3gIKTES4t0/qrsGtrgSWK JZj3Sb6swLNqhbnn0lRUuP7uHlezXx6r55WtsMlE3uBRtQNrIFH/1eF2yU4+wXwtmwTG NxXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=XEQlGV0CNbLAenazRxlS9nooH3k+WVhuTZUz/feXKjU=; b=a+JAZuSpiaVLDvM7P+NZ0AuHdyWQhuirAlMYPqg1poKE3vcrD5jEDMgKM/6+hmIS1M UKlqKDp91A/RxsKtYExlYfYd/806lxj7YfCxQV7EuCRN45M5+V2ezenbl17N1j7uEYct T7iyTJrAC8ZIRMHvG4DLVAIMQ5VbyZi9AexL7f/OKMIwnOQhNI4Csn0klZTDQ99iMM6Z HxpiuIRNutRq8CeiLnGcB5iSwrKz1/i/ej4fvtC6q/n6tXbY2SxNuoUol42u0zpOMfFp 2/Ej/UT+L4E7/s0R9Osn1RM2DUU2Z3ErjbDwgKe6ne/Jml7CfVfllwiR5ivOURFL2Y7W 0Fog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DaEmPQIF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10-v6si1351185pge.674.2018.07.26.07.15.32; Thu, 26 Jul 2018 07:15:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DaEmPQIF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731262AbeGZPbH (ORCPT + 99 others); Thu, 26 Jul 2018 11:31:07 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42201 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730068AbeGZPbG (ORCPT ); Thu, 26 Jul 2018 11:31:06 -0400 Received: by mail-lf1-f67.google.com with SMTP id u202-v6so1303873lff.9; Thu, 26 Jul 2018 07:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XEQlGV0CNbLAenazRxlS9nooH3k+WVhuTZUz/feXKjU=; b=DaEmPQIFInaoqS9o33q0yeXgOHmXvxwl7Onld8P4t9j+a+BI+egWzFGa/tJUB1KRmi dfhgIZf8CanETfiUS3QcQTrKjeIMbXO3/ReGkNONnmgrZ5k31GC92xgkf4c0MTD6gZs7 sWohSmEHmtSAvlwxIxukVm2jBYwYtyiwJYnEgyCo8qERULgrzr5MXbY7aMu/7Z1MHitg RqKlGPvlU97dbu0gW8whqpCDA9dFiXJYcNZ7A2VM/+fZRezgrmQttA3eeg2rsMym0X5Y at4GCtnID+ljC8OJgEVfbTP9gyONOOfBmczt4bt348D0mYCeutBafXgjduuuEqcoq9on m8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XEQlGV0CNbLAenazRxlS9nooH3k+WVhuTZUz/feXKjU=; b=ZUhCsT6UTNF4d5KUcWVViOYV7QvfyFf8TtpdDOfFERoPL0wuzUJAeY3Igu4hwlx2JN ZY4QBQSXJhESWJPwCiov7RpyVh6DcC6N7iWo4WmXABK376KczC9IatVH1Rf//qARc0Du mOVp2OwjEO8wkEtqeM4d76KXWD65HVNkpY/J2gXFPG0vclMWuSvhIWCO46fDP2kfqYSy EwLGRdwbqkJYYq0/ivNVo79xj+ybVQhCxb9LJQyBfI+Wv8FilurxuriiIVCrfcL0ymVd Np1Rlhucar9I7AEXQPtttfY5xK9VwPEGE4wTN41axjbIhHybbyL2gOu9rcOKC4kg4hwy M9vg== X-Gm-Message-State: AOUpUlH3EAzMtyhtAlXvz4CrP/GWiTvbBA4dMnQutZfP9oqQMv7LHytK Bp0HMRBsgli1HTAUH0tc7hQ= X-Received: by 2002:a19:1604:: with SMTP id m4-v6mr1524743lfi.120.1532614441413; Thu, 26 Jul 2018 07:14:01 -0700 (PDT) Received: from ?IPv6:2001:2012:22e:1b00:f2e2:9015:9262:3fde? ([2001:2012:22e:1b00:f2e2:9015:9262:3fde]) by smtp.gmail.com with ESMTPSA id f2-v6sm200013lfb.11.2018.07.26.07.13.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 07:14:00 -0700 (PDT) Subject: Re: [PATCH] 9p: fix NULL pointer dereferences To: Dominique Martinet , Dmitry Vyukov Cc: David Miller , v9fs-developer@lists.sourceforge.net, netdev , LKML , syzkaller References: <20180726081049.10527-1-tomasbortoli@gmail.com> <20180726081727.GA6699@nautica> <20180726094849.GA18334@nautica> From: Tomas Bortoli Openpgp: preference=signencrypt Autocrypt: addr=tomasbortoli@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFpCTZMBEADNZ1+Ibh0Z4pgGRcd1aOUMbe/YfHktmajjcoTnKmZZunjoUVAl8waeLITd BC2c8i1wHzHcnthrmb1izs5XlG6PZnl8n5tjysSNbwggzS1NcEK1qgn5VjNlHQ5aRMUwCC51 kicBiNmlQk2UuzzWwdheRGnaf+O1MNhC0GBeEDKQAL5obOU92pzflv6wWNACr+lHxdnpyies mOnRMjH16NjuTkrGbEmJe+MKp0qbjvR3R/dmFC1wczniRMQmV5w3MZ/N9wRappE+Atc1fOM+ wP7AWNuPvrKg4bN5uqKZLDFH7OFpxvjgVdWM40n0cQfqElWY9as+228Sltdd1XyHtUWRF2VW O1l5L0kX0+7+B5k/fpLhXqD3Z7DK7wRXpXmY59pofk7aFdcN97ZK+r6R7mqrwX4W9IpsPhkT kUyg3/Dx/khBZlJKFoUP325/hoH684bSiPEBroel9alB7gTq2ueoFwy6R3q5CMUw3D+CZWHA 3xllu46TRQ/Vt2g0cIHQNPoye2OWYFJ6kSEvaLpymjNDJ9ph2EuHegonDfOaYSq34ic2BcdB JkCgXRLP5K7KtRNJqqR+DM8xByeGmQv9yp6S97el+SiM9R53RhHawJZGz0EPl+2Q6+5mgh3u wXOlkmGrrSrlB8lc567l34ECl6NFtUPIL7H5vppIXAFl7JZUdQARAQABzR50b21hcyA8dG9t YXNib3J0b2xpQGdtYWlsLmNvbT7CwZQEEwEIAD4WIQSKOZIcNF9TdAG6W8ARUi5Y8x1zLgUC WkJNkwIbIwUJCWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRARUi5Y8x1zLvCXD/9h iaZWJ6bC6jHHPGDMknFdbpNnB5w1hBivu9KwAm4LyEI+taWhmUg5WUNO1CmDa2WGSUSTk9lo uq7gH8Y7zwGrYOEDVuldjRjPFR/1yW2JdAmbwzcYkVU0ZUhyo2XzgFjsnv3vJGHk/afEopce U6mOc2BsGDpo2izVTE/HVaiLE9jyKQF6Riy04QBRAvxbDvx1rl26GIxVI6coBFf4SZhZOnc0 dzsip0/xaSRRIMG0d75weezIG49qK3IHyw2Fw5pEFY8tP0JJVxtrq2MZw+n4WmW9BVD/oCd/ b0JZ4volQbOFmdLzcAi2w7DMcKVkW11I1fiRZ/vLMvA4b79r6mn3WJ8aMIaodG6CQzmDNcsF br+XVp8rc58m9q69BTzDH0xTStxXiwozyISAe2VGbGUbK9ngU/H1RX0Y01uQ9Dz0KfyjA0/Z QOBa4N1n1qoKFzoxTpu0Vyumkc5EnTk8NdWszt7UAtNSaIZcBuWHR7Kp0DqRHwom0kgTiNXJ 8uNgvvFTkPd2Pdz1BqbpN1Fj856xPuKIiqs5qXI2yh3GhntFDbTOwOU3rr3x5NEv3wFVojdi HcLM+KVf29YkRHzuEQT5YT9h6qTk2aFRqq3HSXrP56hQ3whR7bQtziJspkuj+ekeTxcZ5lr4 9FJI03hQJ4HbHn6x/Xw0+WjIOo4jBeUEI87BTQRaQk2TARAA4JCPcQcISPAKKC1n9VQxgdH3 oMqxhJ+gh/0Yb394ZYWLf7qOVQf/MgALPQIIFpcwYrw7gK4hsN7kj1vwPFy9JIqZtkgbmJHm aCj1LkZuf8tp5uvqzMZGcgm28IO6qDhPggeUE3hfA/y5++Vt0Jsmrz5zVPY0bOrLh1bItLnF U3uoaHWkAi/rhM6WwlsxemefzKulXoR9PIGVZ/QGjBGsTkNbTpiz2KsN+Ff/ZgjBJzGQNgha kc6a+eXyGC0YE8fRoTQekTi/GqGY7gfRKkgZDPi0Ul0sPZQJo07Dpw0nh5l6sOO+1yXygcoA V7I4bUeANZ9QJzbzZALgtxbT6jTKC0HUbF9iFb0yEkffkQuhhIqud7RkITe25hZePN8Y6Px0 yF4lEVW/Ti91jMSb4mpZiAaIFcdDV0CAtIYHAcK1ZRVz//+72o4gMZlRxowxduMyRs3L5rE0 ZkFQ6aPan+NBtEk1v3RPqnsQwJsonmiEgfbvybyBpP5MzRZnoAxfQ9vyyXoI5ofbl/+l9wv8 mosKNWIjiQsX3KiyaqygtD/yed5diie5nA7eT6IjL92WfgSelhBCL4jV0fL4w8hah2Azu0Jg 1ZtjjgoDObcAKQ5dLJA0IDsgH/X/G+ZMvkPpPIVaS5QWkiv66hixdKte/4iUrN+4waxJLCit 1KGC2xPJ2UUAEQEAAcLBfAQYAQgAJhYhBIo5khw0X1N0AbpbwBFSLljzHXMuBQJaQk2TAhsM BQkJZgGAAAoJEBFSLljzHXMuOb0P/1EnY4Y6LfQ6bmhJQ6epA3fB70hRWCQsuPYLAgPKRoXy kmWH4ljqQDbA55TtIpnod/woR0IDnZcD7E9cyGzM2rHvSLXTkHhgIWacZHZopAUzq4j0lhiJ Wu57freQPU4rzMVGZXBktUsDMsJwp/3Tl2Kjqylh90qIOlB9laUusLIbl4w5J3EscIJzWvdL y1lJLtBmus/t75wN/aIB8l9YBKGuy0L4SAmjhN52pCgP/S+ANEKvdghQco51a4jD2Pv2uYH7 nUU/Y70AmqOHjPR+qZ0hAUw6B+UtWQ+Fl587Qqi2XPUzdA8G2EjGFFPRlnhf2H/gOyAfeVYL NDwDgm9Yzp7Rx0O1QOnQsXTHqk7K38AdSdM2li/I/zegeblInnLi08Gq6mT6RkD6wV9HE5U3 EIU0rDPyJo54MW39wGjfC2+PM5I0xebbxtnuTewRchVVfm7UWgLAy11pV3xM4wMSJOuqVMOz jYpWKYxDTpvsZ0ginUUY993Gb8k/CxjABEMUGVHhQPZ0OzjHIKS6cTzN6ue8bB+CGOLCaQp1 C0NRT5Tn9zpLxtf5nBExFd/zVENY5vAV2ZbKQdemO54O7j6B9DSgVRrm83GCZxbL4d+qTYBF 3tSCWw/6SG1F3q9gR9QrSC2YRjCmhijUVEh6FhZwB58TNZ1sEEttrps8TDa5tUd9 Message-ID: Date: Thu, 26 Jul 2018 16:13:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180726094849.GA18334@nautica> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/26/2018 11:48 AM, Dominique Martinet wrote: > Dmitry Vyukov wrote on Thu, Jul 26, 2018: >>> Let's refuse that at much higher level, like v9fs_mount() in >>> fs/9p/vfs_super.c >>> >>> I can't think of any valid reason for dev_name to be NULL, it's the >>> target IP or virtio handle. >> >> But I think trans=fd allows NULL addr today, no? > How ? > Ah, right, I read the patch too fast and read unix_create as fd_create, > I never realized there was a unix_create variant... > > fd legitimately doesn't need a name, you are correct. > > I'm really curious if anyone ever uses the unix/fd variants for "real" > stuff though! (not meaning syzbot isn't real, but I have yet to see > anything take advantage of this, even if I could imagine some fun > applications by piping the wmii libixp server socket.. and just crashed > my laptop trying because of the (fixed) trans put bug.. I have yet to > see anyone actually doing this) > > > On the other hand, virtio, rdma and xen all have the same problem, so > Thomas, please fix them instead :) > So just by patching v9fs_mount ?