Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp501778imm; Thu, 26 Jul 2018 07:18:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcnl7VQloWOnia4W4lhQ938XXMOLZFT62YuxRIPlZKhna3JuV1lUroNbyT0J8XXEUsL733r X-Received: by 2002:a63:bf43:: with SMTP id i3-v6mr2175697pgo.342.1532614737236; Thu, 26 Jul 2018 07:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532614737; cv=none; d=google.com; s=arc-20160816; b=IxSnSDn0Q/NYYdDAt4hDR0BIu+EYfGJmGQCOxxqMFf8MbJb5/h+2mdNme8SDjb+a4C wxD2JagGMnS1rnVS6NFRZAKNVe6vQQA0Ec6eTyzlOExybfp5yQcw4HwPVkp4Ai+YgaaU qb78UN8KSusPc8S8ZzC8ZZL3oJQbIbdQ5ACOIva/QczhqzNMDyu/NRG/AgygPRu1+ZcO CnVVwGELdVgd35peZ/DNfyLQYKl4X5+VDQtjfm963nupyFJ9/BoCJlIYEqbu1nsc32V1 gV6I4L+O53bjDBQX/Q3W3BID/csP0qP3Rnp4KqD7ox0H2qrJkKEicIo0oo7IUFGA9zkt kzmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:mime-version:user-agent:date:message-id :cc:to:subject:from:dkim-signature:arc-authentication-results; bh=QIv84B36GI+yM/RQrR2EPODN/OBpNxf8uZJNLY+OWEM=; b=ufS02hvIyqmGu1y/JmgIJhSTTcL5cHB7XM6DXmvjYYOIM3UTED19gf/Ew5WaNUtoJ9 kbRVC2StX8T7WISvPwoqHPtoORaSjkQC51cBbpigfiCAHk643ZJ81x8x6PE3ste+S1JX pYC0JNyagZqCqykBgyFHUIFRwmXfZwIdbqG/Gn0WAVypzQtymxOhvlPMtM6p1XteG6h3 nthtGJm6f1QSSP+B1hbqIdOlhCP1xkshWXnDtnjhVbPOXqm8NgE2pfWkD37gVLrcEY42 JjPV49ZJc2m+DsVvPau2N/AYzyNRGEkdjFVYeijuN/3lbjIhIlUH4/XYT4atLA3dYV2R eA3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PgBxSAPN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4-v6si1391426plk.490.2018.07.26.07.18.41; Thu, 26 Jul 2018 07:18:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PgBxSAPN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730793AbeGZPev (ORCPT + 99 others); Thu, 26 Jul 2018 11:34:51 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44743 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729385AbeGZPev (ORCPT ); Thu, 26 Jul 2018 11:34:51 -0400 Received: by mail-pf1-f194.google.com with SMTP id k21-v6so630837pff.11; Thu, 26 Jul 2018 07:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=QIv84B36GI+yM/RQrR2EPODN/OBpNxf8uZJNLY+OWEM=; b=PgBxSAPN0cFe1nTzDqs4JCu7dcmuAwp/Fbq8rb/CAMiQYR6EyN/oqpO03Og83U47Ze RGKX+QjyQSPVkwJwanLlxrynHD2zcqNqUhq8JFdc4AlTJLFdiGcHrCMHjv6638JjPYWi BP7vK57V2nJ+jcippgrQg8sT/n+Yehvx4rYS44HfpXvFB4Dfs3koO8E/K66KrlCBTZEj J8Y9MNIyH69u9WKllpFcabGt6jXs3gEd9BtYdcmsfydSZW6rGG4QSK8WjRfdjQm4jg1Q hzdnljQ7iRUzynIbaP1GGjxlwhB2QOIKQXrEosUoM0Ok9yFFtCcAg/eFw+rpTrJjY3U/ fqGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=QIv84B36GI+yM/RQrR2EPODN/OBpNxf8uZJNLY+OWEM=; b=ofqu4exqi31u+bZV3a7o4pzwcQO+BbRQZPiDnUYFfoEbx3mGYFr9vcOsc/YABlJjPV xfiT1eTeDD+VisZZtuBwTVw6yrR0yCbtaqQbtlH3Cp2Cbz1Zbk8G+cbPcv7MTwL+bPRP /AkDK+s2wnIFg5gs4aVQ6LXxxi3VT+kRx7uVRVLO+TxiSwIjBwKXHi8k3yxYzILvCVkv +cjTeP8n+D6fl0zwXyWdUaro7T45KhJqMTncYBSqJK+VV2Tr8BeGFw4h8kPPe1DN/ldz MYbJPeAFlQvEXtzAGC5GyaZY1m3zFbgwnTYNyD74zXuFgbvYZuvwDdyX9OJUz4l7OeN0 RaAw== X-Gm-Message-State: AOUpUlGJPU4ujZCDUszP91hI2SAXjZx9o4D0A/Cb76hvOAIdeeRPaVy4 ++5YyHh482R1ooS8WIhyRMX+VwlW X-Received: by 2002:a63:2ec3:: with SMTP id u186-v6mr2114233pgu.225.1532614666803; Thu, 26 Jul 2018 07:17:46 -0700 (PDT) Received: from ?IPv6:2402:f000:1:4414:6c14:7712:e625:1be4? ([2402:f000:1:4414:6c14:7712:e625:1be4]) by smtp.gmail.com with ESMTPSA id m20-v6sm3084483pfg.61.2018.07.26.07.17.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 07:17:46 -0700 (PDT) From: bai Subject: [BUG] video: fbdev: broadsheetfb: Possible null function pointers To: b.zolnierkie@samsung.com Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Date: Thu, 26 Jul 2018 22:17:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In Linux-4.16, drivers/video/fbdev/broadsheetfb.c, 158. static void broadsheet_mmio_send_cmdargs(...) {             ...... 163.     par->board->mmio_write(...);             ...... 166.     par->board->mmio_write(...); 167. } For x86 kernel configuration, I find that there is no assignment of the function pointer ".mmio_write" in the kernel code. So calling the function pointer in lines 163 and 166 may cause a null pointer dereference. In this file, there are many calls to this function pointer... Best wishes, Jia-Ju Bai