Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Jul 2018 18:24:00 +0200
From:   Oleg Nesterov <oleg@redhat.com>
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Wen Yang <wen.yang99@zte.com.cn>,
        majiang <ma.jiang@zte.com.cn>
Subject: Re: [PATCH 18/20] signal: Add calculate_sigpending()
Message-ID: <20180726162400.GB467@redhat.com>
References: <87efft5ncd.fsf_-_@xmission.com>
 <20180724032419.20231-18-ebiederm@xmission.com>
 <20180726132050.GA32718@redhat.com>
 <87tvom58tz.fsf@xmission.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87tvom58tz.fsf@xmission.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/26, Eric W. Biederman wrote:
>
> > Easy to fix, but perhaps we can simply add recalc_sigpending() into
> > schedule_tail() ? It already does more than just finish_task_switch/etc.
> >
> > This way we do not need the new helper (which btw can only be used by
> > copy_process).
>
> The problem I have with reusing recalc_sigpending is that it does not
> set TIF_SIGPENDING if (freezing || klp_patch_pending).

Ah, indeed, you are right.

Oleg.