Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp708141imm; Thu, 26 Jul 2018 10:34:03 -0700 (PDT) X-Google-Smtp-Source: AAOMgpenP7t/eiSwbgVbkUP4F/+yEEXFEjDfSJ7CXlJC5U/L67Ngbo8DKh0RCUuW6OUHyOFNohqp X-Received: by 2002:a17:902:4401:: with SMTP id k1-v6mr995944pld.97.1532626443775; Thu, 26 Jul 2018 10:34:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532626443; cv=none; d=google.com; s=arc-20160816; b=XKh9VuGcxLI/9eFYtk/qf2ubSUDhYqWt7czsZapAStmFPs60/YNQJh3GCxghUg0zyM hkWEdYNqxiLid3BMZueV1GdmWgInbgc44ddYUQZZd8m4fvi1lc0PjkOTUFotjQxsEi0r nRf4xZjzDRTAAuXF9hV/nj1mWzOUFU8Jx2FqUNbRcyW603zQJTRvOZzcmN5eMs7pCcmz oCIEGMXZhwgxKnMVmMW4o6LEkmm/SmnmvzFbHcwVv+k/vxYVff3QF0QxXSmyAyW1IntM j8+UwKslKcO5Xc2+o77PkDqxNh4jM/o+HcErQJWeMn5MeqD5+5W+eGKlGPds6BZoAsgo dh/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=KTAe3scpLuazfhgHMZpshhsIUZ9GbQg4PGd6rFL/aZU=; b=S28p1Poefr1huNCRSvGeDOmz4WDjl2sBeC09vZR/aA5wMqzfCQ+W3oohkamBP9XIqt mIcIInysCh0uEZ0JHPU6eZKm5pAdnzByUO3v0EDGRaLbeSYxnvqLEeI2H2HtA4fO2WB8 wXdmIh5xsyzqWlK6F/gRC9HydZKB+sxishj8yhwRBtWlxNDX0srqEKNUDC2rmpD2eggA IfY9ZSxjgy2rA/zrY9BoQbhz262IG5LHH2PJ65hDluoY1q2XE0YldJuZb3IQXD1ztdxv cHHgldzGLLv1LgVGEiisrn083RZCCLRwi5TjZsSkDux1dxDrZ08GCYX/KmOjDfiD8luF Lrzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l30-v6si1784299plg.12.2018.07.26.10.33.48; Thu, 26 Jul 2018 10:34:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731920AbeGZRsh (ORCPT + 99 others); Thu, 26 Jul 2018 13:48:37 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41942 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730030AbeGZRsg (ORCPT ); Thu, 26 Jul 2018 13:48:36 -0400 Received: from localhost (c-24-20-22-31.hsd1.or.comcast.net [24.20.22.31]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BB70612DE65E2; Thu, 26 Jul 2018 09:31:01 -0700 (PDT) Date: Thu, 26 Jul 2018 09:30:57 -0700 (PDT) Message-Id: <20180726.093057.1929847552946394944.davem@davemloft.net> To: tli012345@163.com Cc: thomas.lendacky@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tangpengpeng@higon.com Subject: Re: [PATCH] net: fix amd-xgbe flow-control issue From: David Miller In-Reply-To: <20180726064516.56740-1-tli012345@163.com> References: <20180726064516.56740-1-tli012345@163.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 09:31:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: tli012345@163.com Date: Thu, 26 Jul 2018 14:45:16 +0800 > From: tangpengpeng > > If we enable or disable xgbe flow-control by ethtool , > it does't work.Because the parameter is not properly > assigned,so we need to adjust the assignment order > of the parameters. > > Signed-off-by: tangpengpeng Applied with -fixes tag added and queued up for -stable.