Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp761384imm; Thu, 26 Jul 2018 11:31:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpchU0MpORwhNCEUZW7LTaGByvA97i+fOUf6lSxgCrDX4a7aSGNZDgWTeZtuFsbBu1I4E79j X-Received: by 2002:a17:902:184:: with SMTP id b4-v6mr3001867plb.340.1532629865726; Thu, 26 Jul 2018 11:31:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532629865; cv=none; d=google.com; s=arc-20160816; b=fDK3fbJdXBcnL82+1R72iyAXAcW2PBVvU2uvx4k9qlNJt7SlNyA8iAk+hQKekVyfVh H9bNU6uPuucZEHdVbjZm92qZQN0Sfi2MbA4752KK2fFdSS5lRw+4Pd6kJ8hZyKFZykaY d0r/C870f89oZc/EpJv03beA3BUG7QdQ09Ds5LPHtDh/8iphJoux1RLCNHxpn0cIwSB2 hfGgocc8g5fIEnSmh8wCs+maed8xAI0TZC5k0V2ywkhCWNXjwS6XgAisg9y4pJTFvqEu Naf3VbWVOfBcTRtxJlXj9YXrx71l8gt51PKzWb/dGuiQaiU4rtUOvYuY6M9NoqiPF3fQ Nu1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=LtACrTE+85dcV3A+vfWuqyFvuhF0COifVAqXhqUWkqQ=; b=THCVHAzwsLQTwfpfvZ5YZEGaeyyaK0YU8np8Wv3UNSrJEv2ec11GyneJw0kQqX6anj 70nqNEBWdvRka5GNRgEBVkqUok0ssw6BmvvmuucTqld+ST9+GOk382+S4n2hLUzKbtjM IlC2gjkX762j/66XKhb8Pu1/FlwPA8coozNEjcjI50yAfpRI5XbPKKevRkm2/0AsNC0C 8Dybt0JuaGhmcSPSJTOQskaQ3SHGsmhtIQe2UCrgg3e/HE8HUNWGk+/zszCK4snYvsJ7 +QMvfm8JnxJraLT8jrQ56hAu5yhKEnqVu4AZfMQiza81Dfk8vjd/QGbp14xZ4pY1JWYb 3+AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y75-v6si1879773pfg.246.2018.07.26.11.30.51; Thu, 26 Jul 2018 11:31:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388776AbeGZTKv (ORCPT + 99 others); Thu, 26 Jul 2018 15:10:51 -0400 Received: from verein.lst.de ([213.95.11.211]:37535 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730764AbeGZTKv (ORCPT ); Thu, 26 Jul 2018 15:10:51 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id D614E68D60; Thu, 26 Jul 2018 19:56:43 +0200 (CEST) Date: Thu, 26 Jul 2018 19:56:43 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Stephen Rothwell , Doug Ledford , Jason Gunthorpe , Linux-Next Mailing List , Linux Kernel Mailing List , Steve Wise Subject: Re: linux-next: build failure after merge of the block tree Message-ID: <20180726175643.GA10765@lst.de> References: <20180726145624.13a604ed@canb.auug.org.au> <20180726084833.GA23310@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 26, 2018 at 10:48:21AM -0700, Jens Axboe wrote: > >> inline_page_count = num_pages(port->inline_data_size); > >> inline_sge_count = max(cm_id->device->attrs.max_sge_rd, > >> - cm_id->device->attrs.max_sge) - 1; > >> + cm_id->device->attrs.max_send_sge) - 1; > > > > This should be max_recv_sge. > > Why do we even have this conflicts to begin with? Because the nvme code added a new user of max_sges while the RDMA tree split it into two separate fields. We discussed this a while ago when the issue came up.