Subject: Re: 2.6.0-test5-mm4: BeFS compile error
From: Will Dyson <will_dyson@pobox.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
In-Reply-To: <20030922114958.GR6325@fs.tum.de>
References: <20030922013548.6e5a5dcf.akpm@osdl.org>
	 <20030922114958.GR6325@fs.tum.de>
Content-Type: text/plain
Message-Id: <1064253433.346.11.camel@thalience>
Mime-Version: 1.0
Date: Mon, 22 Sep 2003 13:57:13 -0400
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 36

On Mon, 2003-09-22 at 07:49, Adrian Bunk wrote:
> On Mon, Sep 22, 2003 at 01:35:48AM -0700, Andrew Morton wrote:
> >...
> > befs-use-parser.patch
> >   BEFS: Use table-driven option parsing
> >...
> 
> It seems this patch broke the compilation of BeFS:
> 
> <--  snip  -->
> 
> ...
>   CC      fs/befs/linuxvfs.o
> fs/befs/linuxvfs.c: In function `parse_options':
> fs/befs/linuxvfs.c:712: too few arguments to function `match_int'
> fs/befs/linuxvfs.c:724: too few arguments to function `match_int'
> make[2]: *** [fs/befs/linuxvfs.o] Error 1

Seems Andrew merged a different version of the options patch than the
one that was posted to the list. I can make a fixup tonight.

Also, from looking at the test5-mm4 patch, I think that match_number()
from lib/parser.c is ignoring the base argument and using a hardcoded
value of zero for the simple_strtol() call. This should result in
match_octal() and match_hex() being broken (well, being the same as
match_int).

-- 
Will Dyson
"Back off man, I'm a scientist!" -Dr. Peter Venkman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/