Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp69741imm; Thu, 26 Jul 2018 14:07:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpesQTs4zcNwsGMw4kyTgeiNSpHhM5amppB1U1LDa8F78j7UBSzJPbNTG5vHALSJu5pndnjw X-Received: by 2002:a62:9cd7:: with SMTP id u84-v6mr3717816pfk.90.1532639263608; Thu, 26 Jul 2018 14:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532639263; cv=none; d=google.com; s=arc-20160816; b=k27Rjz08KoBJls4DUjOHJKul0TWtDhUJpQdMPS+YwO0jbSiI3tMMqV86D5Z73TPNpj AJa0U/WU490mTRbdR18s7UVCU58PNQdBNA8H9/mlVSKkF9tGOq6w/sq1RZA+xImN+K8i areO5dRemzcboqHNi/Az5LkvvHbDhjT8b58K5fUDKduKHbV+NON3EWnVogqIix8GaTlT vdNNVH9AvHz0xuqfdVaDYzYaeA+Tj29davAxeCRQP45nFWn4dDIfEI/NdPb2+ZktGqil IIyeHLTqK+VTHjcxAe9qNMeZ1z6oNJbM4Qt303qYjotLWfwJ8f1kQzC/8zDEOEtpqnXE CgzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=j5pCoXeFgSmCuEHFGMpli7grMtBqRQ/1LrwfxtHjkXA=; b=TccQ6lZAWeitBPLGitv6dJM4rHJbHc9SVgo9E6gELYbb5UTKR/n9NOjXz+3MpygtCg ORSHrbKUqxMP1X92Zu4AQJLrKHlpebbngf2ritVfNGTU8Qk2R4LmyBh+Zw3I7SNoWIQ1 KRaIMx8Vnq9uExso5BD0IpME3Y3zszZ3GGxnoMKD/Qa6aItu7MMG+qOwls9Vvv0F/EVm K6cUigkFi+/Nywetle3JpkpD2fyhBGxmgrTo0lePbdtiL+4G4gereliUKnoeUgsS8/N+ UFcd6daCo9Wme6dE9+NUqFD9YlOuJe7Tr0kaZ/LE+GQJCHLM/HhFMysXAO1OhJE/2rYO OAXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6-v6si2255942pfy.140.2018.07.26.14.07.28; Thu, 26 Jul 2018 14:07:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731648AbeGZWYZ (ORCPT + 99 others); Thu, 26 Jul 2018 18:24:25 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46948 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730452AbeGZWYZ (ORCPT ); Thu, 26 Jul 2018 18:24:25 -0400 Received: from localhost (unknown [172.58.43.154]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 48329108CAEAC; Thu, 26 Jul 2018 14:05:49 -0700 (PDT) Date: Thu, 26 Jul 2018 14:05:48 -0700 (PDT) Message-Id: <20180726.140548.1793684947549084221.davem@davemloft.net> To: yuehaibing@huawei.com Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: Re: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media From: David Miller In-Reply-To: <20180725100049.20244-1-yuehaibing@huawei.com> References: <20180725100049.20244-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 14:05:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Wed, 25 Jul 2018 18:00:49 +0800 > when tipc_own_id failed to obtain node identity,dev_put should > be call before return -EINVAL. > > Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links") > Signed-off-by: YueHaibing Applied to net-next, thank you.