Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neilb@suse.com>
To:     paulmck@linux.vnet.ibm.com
Date:   Fri, 27 Jul 2018 11:04:37 +1000
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Thomas Graf <tgraf@suug.ch>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] rhashtable: don't hold lock on first table throughout insertion.
In-Reply-To: <20180725152250.GN12945@linux.vnet.ibm.com>
References: <153086175009.24852.7782466383056542839.stgit@noble> <20180720075409.kfckhodsnvktift7@gondor.apana.org.au> <20180720144152.GW12945@linux.vnet.ibm.com> <87muulqq8q.fsf@notabene.neil.brown.name> <20180722215446.GH12945@linux.vnet.ibm.com> <87h8kqrhi0.fsf@notabene.neil.brown.name> <20180723205625.GZ12945@linux.vnet.ibm.com> <87r2jtpqm4.fsf@notabene.neil.brown.name> <20180724225825.GE12945@linux.vnet.ibm.com> <87in53oqzz.fsf@notabene.neil.brown.name> <20180725152250.GN12945@linux.vnet.ibm.com>
Message-ID: <87r2jpmqu2.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 25 2018, Paul E. McKenney wrote:
>>=20
>> Looks good ... except ... naming is hard.
>>=20
>>  is_after_call_rcu_init()  asserts where in the lifecycle we are,
>>  is_after_call_rcu() tests where in the lifecycle we are.
>>=20
>>  The names are similar but the purpose is quite different.
>>  Maybe s/is_after_call_rcu_init/call_rcu_init/ ??
>
> How about rcu_head_init() and rcu_head_after_call_rcu()?

Yes, I like those.
Thanks,
NeilBrown

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAltab6YACgkQOeye3VZi
gbkBnw/8CeuzYA5hyw2tgVVSLLbJENMQRI3ZCS4oRl1PFsFgHCJ4Mp5hjwuecZfh
fzvrc0Ug+acesG6QlswuIf34Xp2ved3gc+2gLPaUhMRixl0GlS0S9nDUXWZuIWvh
1PEJiV+GSxE9h3ETML+xGqbff3rW33cYx8ZSzUrVvvNbnaf2ZBN3Zt2oSdqgQPhB
BPGtU7XVrDapC7KTOM56p8lBf760L9gSP1Yx8AEQ7KCzBSdNXCw08UM3chvlVCrx
Am45SZfX4AwqvZFUN3Cvg3CmhD4zyLV+lwCdFuwsYn+O+TlVDOrEldm2WzCcZd2K
SipdmhhctYs7RusZZ9L1g/GDX5dLzuxiuriqqdUwGU0VQKg5H0FMGLrUDsYydXDQ
XDM2Dg8vbN/hjftqK2T24LVn27Mqs3g2bsGF896TE3zyxC1iGSGWst0tne3R6aRn
VwRzFCtXTa7T9cwly/XWjalKABNs2vkzbzBBokgOkf+kdrgVfx++NPQvt5tuv+Ch
zpGVsy8hRzrNmrWDyzC/qGnqDhggYbpjsBn7BETHQQZ5Joke9eSWfk4zW9r9Gi8J
oJuw3trqpZp84lEG2Hgd243vCpttXLIuTYr3nXuCbhAtXMhO67MkPmJ93oQRDo7l
QzZgZj2eQnIqRY9KGnGbjqmVuJLa6F2EAVRuFzrtmo85FBK7MJ8=
=DtVe
-----END PGP SIGNATURE-----
--=-=-=--