Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp369563imm; Thu, 26 Jul 2018 21:25:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcdnFO/mJz4TTL9G5rhYNu6tb9tNXB1ofRfdSdfNvku+mI65qTfBAYJ4+WOPLZjSQlYijNq X-Received: by 2002:a63:e56:: with SMTP id 22-v6mr4569898pgo.438.1532665557363; Thu, 26 Jul 2018 21:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532665557; cv=none; d=google.com; s=arc-20160816; b=KnpfbGXfDYAW9ItT3/BZJaRa74mKUee3DCwqiL7DADL0I3fdZQuup22K6WYPftHCJ8 XCrjMRIqg8oZ/Rpyj3bHEniGm6PzKspHYFGLVuU7LtKaIFJ/h1c9ow26TipQUKKvLqRg bB1H58ZQixTViQBtatXTZPhvwSxHm3lxtF+OOVaMGfA101x6WZLpqPc+Av7Tvi76Gh3I 61lAWadPvYuaTu1s3WGsYMS3lpo0W6rn0cLkRfdo9hvnQsEXEM22iNrvgSz2AP0u1WBM izc2m3pPgCaBdXSc9iAZbniuy45vxindmzVi6rVn1Eh6Ye/WAeEKZJxY20aIcxSidG6X yzpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=3iOOCWQ0PaZqKpzSEuXWx/rnVOM9+LwosxjU9PaJbZ8=; b=ajMEtyVAsae4IYbkKYQnMmwVMNsF+eFEZeAQpDpF0Xp7b/Pme6rCpVdzmyJa6GBsx7 472WQ+ZUQtySJSoH90gZ2nVtjv3X+eFYMYv+oYCwNMQoASLmE7KKCoYxwa5M/avscNeR SadbvM6vrOrSowi/XMAI706sv9F8XrHcwL/3ay3Ru77JheJpTlPewsWUvnD6TdGKztMv 47X1DEITxk3q6qvmiG1Yl1V2fFb0B1kHa+E7MWu0PujgM4KvFfO9xc4KzKX4SpnzZTaG /X5p9I2KCqEKeg6C9bAwtiZkP4s5+GRvl4ZP1atQXkK9DO6PiCu+s+1FV6+ZsHYFGyz8 gmoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i28-v6si3305671pfd.26.2018.07.26.21.25.42; Thu, 26 Jul 2018 21:25:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbeG0Fou (ORCPT + 99 others); Fri, 27 Jul 2018 01:44:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52090 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbeG0Fou (ORCPT ); Fri, 27 Jul 2018 01:44:50 -0400 Received: from localhost (unknown [172.58.35.173]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 95135108C58B9; Thu, 26 Jul 2018 21:24:52 -0700 (PDT) Date: Thu, 26 Jul 2018 21:24:51 -0700 (PDT) Message-Id: <20180726.212451.594057106065516510.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: isdn@linux-pingi.de, keescook@chromium.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: mISDN: hfcpci: Replace GFP_ATOMIC with GFP_KERNEL in hfc_probe() From: David Miller In-Reply-To: <20180727023906.1590-1-baijiaju1990@gmail.com> References: <20180727023906.1590-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 21:24:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 10:39:06 +0800 > hfc_probe() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.