Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp369634imm; Thu, 26 Jul 2018 21:26:02 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdLxe+jY4QMYTiyumHKvI18oOsxkr0Rj1lCnqwIEEWh8ZaIZ6mtojQTMcQ9OfIIYsV/wHWt X-Received: by 2002:a17:902:26:: with SMTP id 35-v6mr4537622pla.276.1532665562599; Thu, 26 Jul 2018 21:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532665562; cv=none; d=google.com; s=arc-20160816; b=04pqRx3+BZmtUGlA6XwwEs/0roT+CtFb65rE1eeYhpnHTpqGvCuf9KaO3I+i4QA51I 97TqkEQ68mZfePVaVkgKsY+Y9URlX5RsE7/BEYczQPmBW+skZAx5MemeRuEi3FthsC2p G58OxFy4Ziz87ytn44ckez8oCrsEYX09ehNh7FalChR+M2Hp4vOhoQfFKiMxWyN5eU32 jDA3vddA9mulC5BbUJLnAYGq7jWLJUsjEuGWqjvGv306ueTBy3Qwb5pmBwYk8NLOP37Y VkGFwBZQLXXu7f41IJcrHbTl8SpWiw0Zikh/bTLiI4Xqip1v1JsHLpnZyrglosUbXQgW 0NBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=9R9X3cSb7n9sba4w/ZBYvQw4u6KSMrKeKFpDWtzPZME=; b=EFkV/6OT+LB/xbpIbgukuAOr/rdKNZYJYE6pyaTLuKQkvTx8PZ0Lg5alCZiNIvOWbE f2aWXTCh0350xsw0gAt9tMZdDiR1Uj0nWDrUBHvVzkt7F/NemEfK+WHuh/1Va6eYeURa WlULXNtPUxxJT9yKwAAfojHQbp4oJ3QrnOrJnqbn2cQSOtvTQA07P8f47ij13dSKyuDK TWKpQPXodBlUK5xH+77EuaOleOXE5QvGy8QczTiGaJ6Z+FjVtjkKmtSy/DfKPs6AI4Ht TGmm8BbFfG3dgZFrDh4Z1XqCpPQlhPRknWCedd8aW6Gw1tW/QO7mb9Lx6l8fYAPS3sCK sdMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n85-v6si3169212pfj.251.2018.07.26.21.25.48; Thu, 26 Jul 2018 21:26:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729431AbeG0Foz (ORCPT + 99 others); Fri, 27 Jul 2018 01:44:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52106 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbeG0Foy (ORCPT ); Fri, 27 Jul 2018 01:44:54 -0400 Received: from localhost (unknown [172.58.35.173]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DDFA1108C58B9; Thu, 26 Jul 2018 21:24:56 -0700 (PDT) Date: Thu, 26 Jul 2018 21:24:56 -0700 (PDT) Message-Id: <20180726.212456.1378755779746007980.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: isdn@linux-pingi.de, keescook@chromium.org, jeyu@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: mISDN: netjet: Replace GFP_ATOMIC with GFP_KERNEL in nj_probe() From: David Miller In-Reply-To: <20180727024109.1702-1-baijiaju1990@gmail.com> References: <20180727024109.1702-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 21:24:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 10:41:09 +0800 > nj_probe() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.