Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp369757imm; Thu, 26 Jul 2018 21:26:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdTFLECZXyB8z4SbSBVPjJLb3u0cwGMUmeBzHk3xhrIitPug6v9UaUB9/poIbLGgBnn4KQl X-Received: by 2002:a62:789:: with SMTP id 9-v6mr4984887pfh.213.1532665573312; Thu, 26 Jul 2018 21:26:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532665573; cv=none; d=google.com; s=arc-20160816; b=rDS6pRqfcaIHsgzxsvfBKF+SpIRo4YlBaOwixsFJeqW8rlOim2GabeobAZwUZR5/vW aZ/xhSc3uyim7F05Vw/MHHfWUU20UkGvffMfGmXh0NRbcyCEYTJ+geROeyL2ugf9JoQr Cg1XTNZ4zbc2PZO7x5WsGa0cGvpwpfl+UZmuZGNlMZoX+eATIRMqLUQTtOVeOYKCl3WQ 6ZQyAxZNP+EiBGA7kPko+wzRodAijhwWySen9bNFZYelou2M9/SGqJw6r2/AfI/To1Cs ql7XjtQsY2aSSiplGig4/eFWbeHurBvqgq2hTVZcPWshXja0ahS5GnaUrPpLhe4ajn8e +f0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=r/jhHM/2pbLeySBuRlr9oZHxvh1jeDC+A/Pk7nSlFS0=; b=QevlFs8RljTCaqwzXn5gWkEMefXpYgvHTHzBeKKkbVgqEFFMHFPevmSnmRkmBi7bP9 nt1kvsiaf/VWoSTk9OVs44RPhT+TUEDNXjZvGr13irT3dVRs4N5vcluBV63IhtQs8ipO EEWeK9NKh7a3ulSnUqTJ6YIji0ycn6U69afCtpOOX7q5ge9U18eZCkMV4Qrw3IJM3hfq +mEKWYAvWdkGmMZ5sYPouq51SRH2FChRQHSpQ3V3vVoB/KUc1dws0uaFLT4XGPqnCYYV g8211BKHCpYNkDBnznHtYaJLS8Ft3bfRh/9xEW3Fa9qRZgYgy1bhJEuvBBs0GvmzTpHm 4jhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n15-v6si3061170pgc.309.2018.07.26.21.25.58; Thu, 26 Jul 2018 21:26:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729460AbeG0FpA (ORCPT + 99 others); Fri, 27 Jul 2018 01:45:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52112 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeG0FpA (ORCPT ); Fri, 27 Jul 2018 01:45:00 -0400 Received: from localhost (unknown [172.58.35.173]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 63F7C108C58B9; Thu, 26 Jul 2018 21:25:02 -0700 (PDT) Date: Thu, 26 Jul 2018 21:25:01 -0700 (PDT) Message-Id: <20180726.212501.877820285744749286.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack() From: David Miller In-Reply-To: <20180727024530.1849-1-baijiaju1990@gmail.com> References: <20180727024530.1849-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 21:25:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 10:45:30 +0800 > init_PStack() is never called in atomic context. > It calls kmalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.