Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp369827imm; Thu, 26 Jul 2018 21:26:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdlY6nycT7DX3KCBfBnjuPPCRHV5+RZY3S9xOGy2p8mgbvEPxvonOPBb5gmUXiwMicuBiFX X-Received: by 2002:a62:5a01:: with SMTP id o1-v6mr5063774pfb.0.1532665580819; Thu, 26 Jul 2018 21:26:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532665580; cv=none; d=google.com; s=arc-20160816; b=uydBlLYP9ZhcDZ+aYyHUQ4Ke3S7UDKYKlHQAqDt+1VRmW9bQshrAtde182tFUv6iZN Jb7p/t9qPZfESwpbrRhny43/tNuzbuS/qEOmo89hJDkLhwT0hMS3GlA6nFwTUeLkzHke zilceL/RazKQovObwv0io8ykM08EKBegH6AE2yzWwE3UL7UkolFvpbeJXVHDwDynj8XX jjTrrYlcKiCphrHjOynyakH4z6oE+lB3Pv1FDHgGxOZjBrREgvn3fzYKtotYnNJptiAz Lc+nOiMMB3sB9m/Nzb6wWc9FZt5ecnj5FlGR96Mv0kYK9IGlNiQT8q1eDE9O02S+N395 eZoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Ci719xgZC2u8JO42e2krP4hISKbpKWnyosLDnCoRgJs=; b=gfwMOAoSbow7CfrWALmsezxKeOWSdLnnl+ifLrk34VCgo6FZuOjkF+X3hoO2cXq5qV fqqM6WqjDBweTOGFqWv/HFzy1ZdXsfDO2d66MtXQzERxZURHgvSSkOiZHnQMFJpNOQ/Y NR7NXcMQJSPgZXECKyvRXsT5Z8HAxWj5Nu2qF+THloiPdrWEzZcWzzo/7LoKHaU1pag9 F85bELwfYZoRMtM1xN9FUBdqUMRks2GpCPq+6uZMPHP5Xfc1qrCPo1P9wpoISXnq1Hi0 eUKnglzuDIBAK57B1ghLwuSYpE4RegCtL2VD8/0gdG3IdqOy94DRlTPp2zHNQLyBwiQn 4DUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u64-v6si3080306pfd.297.2018.07.26.21.26.06; Thu, 26 Jul 2018 21:26:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729493AbeG0FpF (ORCPT + 99 others); Fri, 27 Jul 2018 01:45:05 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52122 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeG0FpF (ORCPT ); Fri, 27 Jul 2018 01:45:05 -0400 Received: from localhost (unknown [172.58.35.173]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CF5A2108C58B9; Thu, 26 Jul 2018 21:25:07 -0700 (PDT) Date: Thu, 26 Jul 2018 21:25:07 -0700 (PDT) Message-Id: <20180726.212507.209809359488602241.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: hisax: config: Replace GFP_ATOMIC with GFP_KERNEL From: David Miller In-Reply-To: <20180727024828.2107-1-baijiaju1990@gmail.com> References: <20180727024828.2107-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 21:25:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 10:48:28 +0800 > hisax_cs_new() and hisax_cs_setup() are never called in atomic context. > They call kmalloc() and kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.