Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp369932imm; Thu, 26 Jul 2018 21:26:30 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf54CeXJhWi3ONmbdN30892BSKmzXFY0PwCTTPI43x74zTuBO360irdGPjSLgnky/0Whb/Q X-Received: by 2002:a62:87ce:: with SMTP id i197-v6mr5030612pfe.62.1532665590915; Thu, 26 Jul 2018 21:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532665590; cv=none; d=google.com; s=arc-20160816; b=XeNK88QtZPw00DaLhvPfW54xF4QDH0DJ1DIMVGM+vpkDoYQ6nX8QHLhkWRVZU+6QkI c6216+a0xviSH9eE8D5mqFoih2ado1mKqRmBb/m6YJO7mA7z4+xsMJz89gXZnUEsf9AX h1ak9i5501qP7+/zHyvT8Nfc52dJOEGUpiPp/EKUyvCNZs/VgTGBS5r/CH0S/vnY12Q8 6WleAmjqLugiFFX+sGqtWWHALjKAwZb0YSqzn4h23pvTbBuP0AgGDhl8sBBadQKWf+ks SAH9Rbzw6bl01hvhUvjonRKUIePIoF5hRzTiL8db3tooyg+eW+CXaaLkyK+ZjrxZt7Rk KNAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=NMPR69F6b1PGuf9U3bISkomoneg80JXGnNMeaKburDQ=; b=bDn2NymxODGC4/psgPRkyuAj8I/ZGecrBADVee1n5o+HpMqwLEa8uUePPPqs6i7VE7 HxJk5BXlw16M0QKaeC/z2xWJkdqTuOQ0bk+LAUDuqJYeOhnnlnbct+O+FyOTH6tm+juy Pj4E99by9fAMnabpOVe9vIFoL2It9PalB6njziG0s0eVyhd6hMaBWyrykElhO0bbdwfT FlFUbG7F9g32/EoUnGVNYwR5FoXlyWF8+cIS0ymCcC5xyeKhiGVtEqZFWaepQQQ60cKv gqpybcNMHNmBkF+b/cVz7+0d6Tt77fp/etIt6R08zsaMSkYXQjEcHY6UaaBql7vfkLYw Cwlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8-v6si2987022pgr.461.2018.07.26.21.26.16; Thu, 26 Jul 2018 21:26:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729544AbeG0FpL (ORCPT + 99 others); Fri, 27 Jul 2018 01:45:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52128 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeG0FpL (ORCPT ); Fri, 27 Jul 2018 01:45:11 -0400 Received: from localhost (unknown [172.58.35.173]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 027B0108C58B9; Thu, 26 Jul 2018 21:25:13 -0700 (PDT) Date: Thu, 26 Jul 2018 21:25:13 -0700 (PDT) Message-Id: <20180726.212513.177438672592617851.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: ionut@badula.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: adaptec: Replace mdelay() with msleep() in starfire_init_one() From: David Miller In-Reply-To: <20180727035106.5185-1-baijiaju1990@gmail.com> References: <20180727035106.5185-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jul 2018 21:25:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 11:51:06 +0800 > starfire_init_one() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.