Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp470653imm; Thu, 26 Jul 2018 23:55:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdIAcj4urmX6gLGecC8vT3jqQrjccJUvIRT5w3GKYOeR2k6rj9rtJVgS4ypkF0XXZVfXf5Z X-Received: by 2002:a63:89c7:: with SMTP id v190-v6mr4769218pgd.194.1532674512747; Thu, 26 Jul 2018 23:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532674512; cv=none; d=google.com; s=arc-20160816; b=ZgjqbZpZB9azkskVntwG6S8YtXq16sYjN8sdSrnp4Xyn71joLL5X7NFc6Ysvg2Loat Vh7caGS2ofuAPk+imCq9v0e0WQhaKQSZ6h0hSUB4+8ilwFb/gQMh2CYsnjtP+YvtJz5W 3yz1TVE9B+DYfrE4urxZGyjGC0W7efm4p8gZVG+6YTwpo4K7u+oJ9yfOU1xNdpIeeNaV 8wVuoBW0jRNXq0IDe+78Wx6bI/6f72dsRHf43MaYopf74paTLrtzrIWZpGiOyxFXUB97 UV7Cdit0dimkoGQZAYfE7UsDeiS3ME25nZ/KBdVi+9oEQfKtGeOUau4cpwmUdI9ql6PA cBbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=69tJWUC9Msla685I8H0mh1raHwcPFk0JuxKRrjm2bLI=; b=nvqRMEaS8Yh1QybG32+5qGGbuVP9NFO5JPzUlM+zgk8rzKlw7pKeadcFWYarGG7Vzy YE6LCvDo1OKLUfzEh2SZEvO/4sRIdEmVkN59McnUr5PzAgLm4rZKwPMlC5zLIhEIhzNk mMd4ZKfNGXP+3dhGCl5s9ZP8hOnNES2cf4zHI1GDyx81TDD682Xz4Wz+VvopvwWjpVXI 3Us+qhUtZN/MtL5zkxk8XzfHmoM/GOniAkYr7VOBBo/zszEeh3cEzz5npi76Ru39pq8z UREbD1sOzCpa9irrdCGL6d8QQNLwHvZ2N5Vd14zEiwkrSn4joTKwndOHF9tVcHxSoY53 OY7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q145-v6si3424790pfq.315.2018.07.26.23.54.55; Thu, 26 Jul 2018 23:55:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729581AbeG0INI (ORCPT + 99 others); Fri, 27 Jul 2018 04:13:08 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59317 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbeG0INH (ORCPT ); Fri, 27 Jul 2018 04:13:07 -0400 X-Originating-IP: 81.250.144.103 Received: from [10.30.1.20] (LNeuilly-657-1-5-103.w81-250.abo.wanadoo.fr [81.250.144.103]) (Authenticated sender: alex@ghiti.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CE5722000A; Fri, 27 Jul 2018 06:52:15 +0000 (UTC) Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives To: Mike Kravetz , Michael Ellerman , Michal Hocko Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Naoya Horiguchi , "Aneesh Kumar K . V" References: <20180705110716.3919-1-alex@ghiti.fr> <20180709141621.GD22297@dhcp22.suse.cz> <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> <75195a7d-3d0f-4e55-92cc-4ad772683c75@oracle.com> <87tvomgqyv.fsf@concordia.ellerman.id.au> <99473e0d-12d8-bbea-fe9c-4e3738ab7f5a@oracle.com> From: Alexandre Ghiti Message-ID: Date: Fri, 27 Jul 2018 08:51:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <99473e0d-12d8-bbea-fe9c-4e3738ab7f5a@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Level: * Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, Thanks for your review. I'm going to fix the 2nd patch as you said, you're right, no need to move the #include at the bottom of the file. I'm going to post a v5, add -mm in cc and ask for inclusion in their tree. Thanks again for your time, Alex On 07/26/2018 09:16 PM, Mike Kravetz wrote: > On 07/26/2018 04:46 AM, Michael Ellerman wrote: >> Mike Kravetz writes: >> >>> On 07/20/2018 11:37 AM, Alex Ghiti wrote: >>>> Does anyone have any suggestion about those patches ? >>> I only took a quick look. From the hugetlb perspective, I like the >>> idea of moving routines to a common file. If any of the arch owners >>> (or anyone else) agree, I can do a review of the series. >> The conversions look pretty good to me. If you want to give it a review >> then from my point of view it could go in -mm to shake out any bugs. > Nothing of significance found in a review. As others have suggested, > the (cross)compiler may be better at finding issues than human eyes. > > I also suggest it be added to -mm.