Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anurag Kumar Vulisha <anuragku@xilinx.com>
To:     Felipe Balbi <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb: dwc3: core: Add quirk for enabling AutoRetry
 feature in the controller
Thread-Topic: [PATCH v2] usb: dwc3: core: Add quirk for enabling AutoRetry
 feature in the controller
Thread-Index: AQHUJN2BN6j+pPNjJUq6AkpLiXk/dqShckiAgAACXHA=
Date:   Fri, 27 Jul 2018 07:29:37 +0000
Message-ID: <MWHPR02MB281661D98648F430989697E8A72A0@MWHPR02MB2816.namprd02.prod.outlook.com>
References: <1532608663-4091-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <87va92yxrs.fsf@linux.intel.com>
In-Reply-To: <87va92yxrs.fsf@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 310387c5-c1b9-48a6-7afb-08d5f392b55c
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2018 07:29:37.5234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3168
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Felipe,

Thanks again for reviewing the patch. Will make the suggested changes and s=
end v3.

Thanks,
Anurag Kumar Vulisha

>-----Original Message-----
>From: Felipe Balbi [mailto:balbi@kernel.org]
>Sent: Thursday, July 26, 2018 6:12 PM
>To: Anurag Kumar Vulisha <anuragku@xilinx.com>; gregkh@linuxfoundation.org
>Cc: v.anuragkumar@gmail.com; linux-usb@vger.kernel.org; linux-
>kernel@vger.kernel.org; Anurag Kumar Vulisha <anuragku@xilinx.com>
>Subject: Re: [PATCH v2] usb: dwc3: core: Add quirk for enabling AutoRetry =
feature in
>the controller
>
>
>Hi,
>
>Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> writes:
>> By default when core sees any transaction error(CRC or overflow) it
>> replies with terminating retry ACK (Retry=3D1 and Nump =3D=3D 0).
>> Enabling this Auto Retry feature in controller, on seeing any
>> transaction errors makes the core to send a non-terminating ACK
>> transaction packet (that is, ACK TP with Retry=3D1 and Nump !=3D 0).
>> Doing so will give controller a chance to recover from the error
>> condition.
>>
>> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
>> ---
>>  Changes in v2:
>> 	1. As suggested by Rob Herring & Felipe Balbi removed the
>> 	   quirk logic and setting the AutoRetry bits unconditionally
>> 	   for hostmode
>> ---
>>  drivers/usb/dwc3/core.c | 14 ++++++++++++++  drivers/usb/dwc3/core.h
>> |  3 +++
>>  2 files changed, 17 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
>> 1038075..478c8a6 100644
>> --- a/drivers/usb/dwc3/core.c
>> +++ b/drivers/usb/dwc3/core.c
>> @@ -883,6 +883,20 @@ static int dwc3_core_init(struct dwc3 *dwc)
>>  		dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
>>  	}
>>
>> +	if (dwc->dr_mode =3D=3D USB_DR_MODE_HOST) {
>
>almost there. You also wanna check for dr_mode =3D=3D OTG. OTG configurati=
ons can
>switch between device and host mode at will.
>
>> +		reg =3D dwc3_readl(dwc->regs, DWC3_GUCTL);
>> +
>> +		/* Enable Auto retry Feature to make the controller operating in
>
>match the multi-line comment style already in this file:
>
>	/*
>         * Enable Auto ....
>
>--
>balbi