Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Jul 2018 17:04:48 +0800
From:   "liujunliang_ljl@163.com" <liujunliang_ljl@163.com>
To:     "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc:     linux-usb <linux-usb@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Jia-Ju Bai" <baijiaju1990@gmail.com>
Subject: Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
References: <20180727084104.29726-1-baijiaju1990@gmail.com>
Mime-Version: 1.0
Message-ID: <201807271704468308230@163.com>
Content-Type: multipart/alternative;
        boundary="----=_001_NextPart884175411161_=----"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is a multi-part message in MIME format.

------=_001_NextPart884175411161_=----
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: base64

RGVhciBKaWEtSnUgQmFpIDoNCg0KICAgICAgICAgICAgT0suDQoNCiAgICAgICAgICAgIHRoZSBw
YXRjaCBpcyBvay4NCg0KDQoNCmxpdWp1bmxpYW5nX2xqbEAxNjMuY29tDQogDQpGcm9tOiBKaWEt
SnUgQmFpDQpEYXRlOiAyMDE4LTA3LTI3IDE2OjQxDQpUbzogbGl1anVubGlhbmdfbGpsDQpDQzog
bGludXgtdXNiOyBuZXRkZXY7IGxpbnV4LWtlcm5lbDsgSmlhLUp1IEJhaQ0KU3ViamVjdDogW1BB
VENIXSBuZXQ6IHVzYjogc3I5NzAwOiBSZXBsYWNlIG1kZWxheSgpIHdpdGggbXNsZWVwKCkgaW4g
c3I5NzAwX2JpbmQoKQ0Kc3I5NzAwX2JpbmQoKSBpcyBuZXZlciBjYWxsZWQgaW4gYXRvbWljIGNv
bnRleHQuDQpJdCBjYWxscyBtZGVsYXkoKSB0byBidXNpbHkgd2FpdCwgd2hpY2ggaXMgbm90IG5l
Y2Vzc2FyeS4NCm1kZWxheSgpIGNhbiBiZSByZXBsYWNlZCB3aXRoIG1zbGVlcCgpLg0KIA0KVGhp
cyBpcyBmb3VuZCBieSBhIHN0YXRpYyBhbmFseXNpcyB0b29sIG5hbWVkIERDTlMgd3JpdHRlbiBi
eSBteXNlbGYuDQogDQpTaWduZWQtb2ZmLWJ5OiBKaWEtSnUgQmFpIDxiYWlqaWFqdTE5OTBAZ21h
aWwuY29tPg0KLS0tDQpkcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMgfCAyICstDQoxIGZpbGUgY2hh
bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCiANCmRpZmYgLS1naXQgYS9kcml2
ZXJzL25ldC91c2Ivc3I5NzAwLmMgYi9kcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMNCmluZGV4IDJk
MzE2YzFiODUxYi4uNmFjMjMyZTUyYmY3IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9uZXQvdXNiL3Ny
OTcwMC5jDQorKysgYi9kcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMNCkBAIC0zNTgsNyArMzU4LDcg
QEAgc3RhdGljIGludCBzcjk3MDBfYmluZChzdHJ1Y3QgdXNibmV0ICpkZXYsIHN0cnVjdCB1c2Jf
aW50ZXJmYWNlICppbnRmKQ0KLyogcG93ZXIgdXAgYW5kIHJlc2V0IHBoeSAqLw0Kc3Jfd3JpdGVf
cmVnKGRldiwgU1JfUFJSLCBQUlJfUEhZX1JTVCk7DQovKiBhdCBsZWFzdCAxMG1zLCBoZXJlIDIw
bXMgZm9yIHNhZmUgKi8NCi0gbWRlbGF5KDIwKTsNCisgbXNsZWVwKDIwKTsNCnNyX3dyaXRlX3Jl
ZyhkZXYsIFNSX1BSUiwgMCk7DQovKiBhdCBsZWFzdCAxbXMsIGhlcmUgMm1zIGZvciByZWFkaW5n
IHJpZ2h0IHJlZ2lzdGVyICovDQp1ZGVsYXkoMiAqIDEwMDApOw0KLS0gDQoyLjE3LjANCg==

------=_001_NextPart884175411161_=----
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charse=
t=3Dus-ascii"><style>body { line-height: 1.5; }blockquote { margin-top: 0p=
x; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font=
-family: ????; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><bod=
y>=0A<div><span></span>Dear Jia-Ju Bai :</div><div><br></div><div><span st=
yle=3D"color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">&nbsp; &n=
bsp;&nbsp;</span><span style=3D"background-color: rgba(0, 0, 0, 0); font-s=
ize: 10.5pt; line-height: 1.5;">&nbsp; &nbsp;&nbsp;</span><span style=3D"b=
ackground-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;">&=
nbsp; &nbsp; OK.</span></div><div><span style=3D"background-color: rgba(0,=
 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"><br></span></div><div><sp=
an style=3D"color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">&nbs=
p; &nbsp;&nbsp;</span><span style=3D"background-color: rgba(0, 0, 0, 0); f=
ont-size: 10.5pt; line-height: 1.5;">&nbsp; &nbsp;&nbsp;</span><span style=
=3D"background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.=
5;">&nbsp; &nbsp; the patch is ok.</span></div>=0A<div><br></div><hr style=
=3D"WIDTH: 210px; HEIGHT: 1px" color=3D"#b5c4df" size=3D"1" align=3D"left"=
>=0A<div><span><div style=3D"MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE=
: 10pt"><div>liujunliang_ljl@163.com</div></div></span></div>=0A<blockquot=
e style=3D"margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;"><div>=
&nbsp;</div><div style=3D"border:none;border-top:solid #B5C4DF 1.0pt;paddi=
ng:3.0pt 0cm 0cm 0cm"><div style=3D"PADDING-RIGHT: 8px; PADDING-LEFT: 8px;=
 FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PA=
DDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b>&nbsp;<a href=3D"mai=
lto:baijiaju1990@gmail.com">Jia-Ju Bai</a></div><div><b>Date:</b>&nbsp;201=
8-07-27&nbsp;16:41</div><div><b>To:</b>&nbsp;<a href=3D"mailto:liujunliang=
_ljl@163.com">liujunliang_ljl</a></div><div><b>CC:</b>&nbsp;<a href=3D"mai=
lto:linux-usb@vger.kernel.org">linux-usb</a>; <a href=3D"mailto:netdev@vge=
r.kernel.org">netdev</a>; <a href=3D"mailto:linux-kernel@vger.kernel.org">=
linux-kernel</a>; <a href=3D"mailto:baijiaju1990@gmail.com">Jia-Ju Bai</a>=
</div><div><b>Subject:</b>&nbsp;[PATCH] net: usb: sr9700: Replace mdelay()=
 with msleep() in sr9700_bind()</div></div></div><div><div>sr9700_bind() i=
s never called in atomic context.</div>=0A<div>It calls mdelay() to busily=
 wait, which is not necessary.</div>=0A<div>mdelay() can be replaced with =
msleep().</div>=0A<div>&nbsp;</div>=0A<div>This is found by a static analy=
sis tool named DCNS written by myself.</div>=0A<div>&nbsp;</div>=0A<div>Si=
gned-off-by: Jia-Ju Bai &lt;baijiaju1990@gmail.com&gt;</div>=0A<div>---</d=
iv>=0A<div> drivers/net/usb/sr9700.c | 2 +-</div>=0A<div> 1 file changed, =
1 insertion(+), 1 deletion(-)</div>=0A<div>&nbsp;</div>=0A<div>diff --git =
a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c</div>=0A<div>index 2=
d316c1b851b..6ac232e52bf7 100644</div>=0A<div>--- a/drivers/net/usb/sr9700=
.c</div>=0A<div>+++ b/drivers/net/usb/sr9700.c</div>=0A<div>@@ -358,7 +358=
,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *int=
f)</div>=0A<div> 	/* power up and reset phy */</div>=0A<div> 	sr_write_reg=
(dev, SR_PRR, PRR_PHY_RST);</div>=0A<div> 	/* at least 10ms, here 20ms for=
 safe */</div>=0A<div>-	mdelay(20);</div>=0A<div>+	msleep(20);</div>=0A<di=
v> 	sr_write_reg(dev, SR_PRR, 0);</div>=0A<div> 	/* at least 1ms, here 2ms=
 for reading right register */</div>=0A<div> 	udelay(2 * 1000);</div>=0A<d=
iv>-- </div>=0A<div>2.17.0</div>=0A</div></blockquote>=0A</body></html>
------=_001_NextPart884175411161_=------