Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Jul 2018 11:49:58 +0200
Message-ID: <s5hwothxb21.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc:     <bhumirks@gmail.com>, <perex@perex.cz>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: pci: cthw20k2: Replace mdelay() with msleep() and usleep_range()
In-Reply-To: <20180727090143.18686-1-baijiaju1990@gmail.com>
References: <20180727090143.18686-1-baijiaju1990@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 27 Jul 2018 11:01:43 +0200,
Jia-Ju Bai wrote:
> 
> hw_pll_init(), hw_dac_stop(), hw_dac_start() and hw_adc_init() 
> are never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied, thanks.


Takashi