Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263058AbTIVVog (ORCPT ); Mon, 22 Sep 2003 17:44:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263060AbTIVVog (ORCPT ); Mon, 22 Sep 2003 17:44:36 -0400 Received: from twilight.ucw.cz ([81.30.235.3]:40149 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id S263058AbTIVVoe (ORCPT ); Mon, 22 Sep 2003 17:44:34 -0400 Date: Mon, 22 Sep 2003 23:44:19 +0200 From: Vojtech Pavlik To: Andrew Morton Cc: Zilvinas Valinskas , alistair@devzero.co.uk, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vojtech Pavlik Subject: Re: 2.6.0-test5-mm4 Message-ID: <20030922214419.GC2983@ucw.cz> References: <20030922013548.6e5a5dcf.akpm@osdl.org> <200309221317.42273.alistair@devzero.co.uk> <20030922143605.GA9961@gemtek.lt> <20030922115509.4d3a3f41.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922115509.4d3a3f41.akpm@osdl.org> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 42 On Mon, Sep 22, 2003 at 11:55:09AM -0700, Andrew Morton wrote: > Zilvinas Valinskas wrote: > > > > Btw Andrew , > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > You mean it breaks the XFree driver? Is it just a matter of editing > XF86Config to tell it the new protocl name? Ouch? This is just an information string, it is not supposed to be used anywhere except printks etc ... I really HOPE nobody is parsing these strings. Before the patch, the input_dev.name string said "Synaptics Synaptics Pad", which kind of didn't make much sense. Since it's a concatenation of protocol, vendor and device names, it now says "SynPS/2 Synaptics Pad", which sounds a bit better. > Either way, it looks like a change which should be reverted? If it breaks anything, that needs to be fixed in what it broke, because nothing should depend on this. If it does, then that's a big bug. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/