Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     Douglas Anderson <dianders@chromium.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "Minas.Harutyunyan@synopsys.com" <Minas.Harutyunyan@synopsys.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
        "grigor.tovmasyan@synopsys.com" <grigor.tovmasyan@synopsys.com>,
        "Bruno Herrera" <bruherrera@gmail.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his"
 platforms
Thread-Topic: [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his"
 platforms
Thread-Index: AQHUJRxd9SEVjTDe0kKxyJR8PXT+bQ==
Date:   Fri, 27 Jul 2018 11:00:49 +0000
Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBDD3@am04wembxa.internal.synopsys.com>
References: <20180726200730.18290-1-dianders@chromium.org>
 <20180726200730.18290-3-dianders@chromium.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/27/2018 12:08 AM, Douglas Anderson wrote:=0A=
> There's no reason to have the uframe scheduler off on dwc2.  Running=0A=
> with uframe_sched =3D False is equivalent to saying "I don't want to run=
=0A=
> the correct code, I want to run the old and incorrect code".=0A=
> =0A=
> The uframe scheduler has been off on HiSilicon since commit=0A=
> 37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there=0A=
> have been many many improvements, notably the commit 9f9f09b048f5=0A=
> ("usb: dwc2: host: Totally redo the microframe scheduler")=0A=
> =0A=
> Presumably if everyone is good w/ the uframe_sched turned back on we=0A=
> can kill all the old and crufty non-uframe sched code.=0A=
> =0A=
> Signed-off-by: Douglas Anderson <dianders@chromium.org>=0A=
> Tested-by: John Stultz <john.stultz@linaro.org>=0A=
Acked-by: Minas Harutyunyan <hminas@synopsys.com>=0A=
=0A=
> ---=0A=
> =0A=
>   drivers/usb/dwc2/params.c | 1 -=0A=
>   1 file changed, 1 deletion(-)=0A=
> =0A=
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c=0A=
> index 14b8742e62fa..db97bb16ecc4 100644=0A=
> --- a/drivers/usb/dwc2/params.c=0A=
> +++ b/drivers/usb/dwc2/params.c=0A=
> @@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsot=
g)=0A=
>   	p->reload_ctl =3D false;=0A=
>   	p->ahbcfg =3D GAHBCFG_HBSTLEN_INCR16 <<=0A=
>   		GAHBCFG_HBSTLEN_SHIFT;=0A=
> -	p->uframe_sched =3D false;=0A=
>   	p->change_speed_quirk =3D true;=0A=
>   	p->power_down =3D false;=0A=
>   }=0A=
> =0A=
=0A=