Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp673081imm; Fri, 27 Jul 2018 04:12:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf1m0arS+jm6cllMbCzHV5uUWzFzdRkuNEzg1s4KKurTAFOkHaj3tqC7qmkdgavuRC3SuoW X-Received: by 2002:a63:dd09:: with SMTP id t9-v6mr5788289pgg.370.1532689969016; Fri, 27 Jul 2018 04:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532689968; cv=none; d=google.com; s=arc-20160816; b=VwVqUyt/6lrtLRM2hF28H5j7unUzh7AabsrZBVRKbtfS9Jz1SREo3KAGbp5DLK75bm Gfpcmn31B481wMLBi82z1BiqV0TIshbSfcvlWW+2O1GkktK3LUTS5N9Gum4N3XTxvm5w h/+N9KNdI2WqK+6YBA3EM7QIO845Syg9LGtu4G8JXz1T3ONkD6gy+6e2H/X7XaAlB95M /K0COMm0dkzRJgm5aWx82EqYQMO1yCTe7A0aLOc2HikEOXwfSfwsKcvhQFqMcrmQI8sR KH+aCxbUzZAXGerXJZZlk4DjedblAgJCNSE1rPiZqGyIwVbxv4sInGBBfqcG7s86yF5F UeWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=TDp90pt/W4XA7xEhsS499bSuoRxxy/DmdcNq8VkdOQo=; b=mrBYZyWIEhfbaST3hMT30mKNyVG6ijULHF7XN2zS0x2M/hCBG+JB0mQhqjjrTJlpS3 55CK4ttabnJahwcwvhv5lcPwMYXtG8kVbaIoCdp5F4zeyiPIXWY2/OFc3cLAFVpv2hdF w+PTJlavr1v778jKrH6HW0AdWXp6pSKubJOp0mj3CuHsAznhN/+HQB9VhyDWv+j/Vbfl hHyiqFt5mxbgjZopswB2We47qqRTH+334+LmFkor3dHb1B5SyJ2uBGivZo4mvkInKnxc Qd8nM1MdyuX/QJVbP59o80HW7hNiFPOAlYlNlrcvPpgeTUj5nrb3dxks9vGpy7U7m2b1 MFBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=VlfoDkD6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13-v6si3718277pgh.213.2018.07.27.04.12.34; Fri, 27 Jul 2018 04:12:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=VlfoDkD6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732121AbeG0Mcb (ORCPT + 99 others); Fri, 27 Jul 2018 08:32:31 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:53372 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730290AbeG0Mca (ORCPT ); Fri, 27 Jul 2018 08:32:30 -0400 Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238]) by smtprelay.synopsys.com (Postfix) with ESMTP id 5EADA24E0396; Fri, 27 Jul 2018 04:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1532689864; bh=23uReKFiTvinKImWq2aBjmupK0oFWfOYXhWxiKRuWns=; h=From:To:CC:Subject:Date:References:From; b=VlfoDkD6kvn7wTNuHFmkXxyqh3yWrX/JIvBvtW/GdlVlLZ1g2cPlATNICOuHp0PpS nd4FejSGIJvULAizO4cn0ujle8OQxP+94VNZaaxiRWhoCPmsxEghFuD4Ol1x9v57Ep /G7HN2UGTc6Qx8JaXOWMTEK2fSW/NHxgNp2o0QKoYxiEUWYHnMxpa0J4rvN/PesGs9 ngu3V8S2VPspRexex+VNpje1ZtZwPXtWdxSyEpWuVzuHdTDrUuXDuo6Hy3UcNuO44m CGFikKiuZnf8nsYePTqwWBqdt3lDUVz8Io+QG2GiguG89mUmd2kdhLlookv0sa0gjb 5HR2Dx3FuiOzQ== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) by mailhost.synopsys.com (Postfix) with ESMTP id 3DEA43A9A; Fri, 27 Jul 2018 04:11:04 -0700 (PDT) Received: from AM04WEHTCA.internal.synopsys.com (10.116.16.190) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 27 Jul 2018 04:11:04 -0700 Received: from AM04WEMBXA.internal.synopsys.com ([fe80::79c3:55f2:1f20:5bf4]) by am04wehtca.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Fri, 27 Jul 2018 15:11:01 +0400 From: Minas Harutyunyan To: Douglas Anderson , "balbi@kernel.org" , "Minas.Harutyunyan@synopsys.com" , "gregkh@linuxfoundation.org" CC: "stefan.wahren@i2se.com" , "grigor.tovmasyan@synopsys.com" , "Bruno Herrera" , Zhangfei Gao , "john.stultz@linaro.org" , Stephen Warren , Jerome Brunet , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Thread-Topic: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Thread-Index: AQHUJRxeUWy2qj6wI0S5d3VRi5vBAA== Date: Fri, 27 Jul 2018 11:11:00 +0000 Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE48@am04wembxa.internal.synopsys.com> References: <20180726200730.18290-1-dianders@chromium.org> <20180726200730.18290-4-dianders@chromium.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.151] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/2018 12:08 AM, Douglas Anderson wrote:=0A= > There's no reason to have the uframe scheduler off on dwc2. Running=0A= > with uframe_sched =3D False is equivalent to saying "I don't want to run= =0A= > the correct code, I want to run the old and incorrect code".=0A= > =0A= > The uframe scheduler has been off on Amlogic since commit f94310ac076e=0A= > ("usb: dwc2: add support for Meson8b and GXBB SoCs"). While this was=0A= > after most of the recent improvements, notably the commit 9f9f09b048f5=0A= > ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably=0A= > the parameters were copied from another platform and the uframe=0A= > scheduler wasn't tried.=0A= > =0A= > Presumably if everyone is good w/ the uframe_sched turned back on we=0A= > can kill all the old and crufty non-uframe sched code.=0A= > =0A= > Signed-off-by: Douglas Anderson =0A= =0A= Reviewed-by: Minas Harutyunyan =0A= =0A= > ---=0A= > =0A= > drivers/usb/dwc2/params.c | 1 -=0A= > 1 file changed, 1 deletion(-)=0A= > =0A= > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c=0A= > index db97bb16ecc4..93380f7c32b4 100644=0A= > --- a/drivers/usb/dwc2/params.c=0A= > +++ b/drivers/usb/dwc2/params.c=0A= > @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg= *hsotg)=0A= > p->phy_type =3D DWC2_PHY_TYPE_PARAM_UTMI;=0A= > p->ahbcfg =3D GAHBCFG_HBSTLEN_INCR8 <<=0A= > GAHBCFG_HBSTLEN_SHIFT;=0A= > - p->uframe_sched =3D false;=0A= > }=0A= > =0A= > static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)=0A= > =0A= =0A=