Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     Douglas Anderson <dianders@chromium.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "Minas.Harutyunyan@synopsys.com" <Minas.Harutyunyan@synopsys.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
        "grigor.tovmasyan@synopsys.com" <grigor.tovmasyan@synopsys.com>,
        "Bruno Herrera" <bruherrera@gmail.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on
 "stm32f4x9_fsotg" platforms
Thread-Topic: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on
 "stm32f4x9_fsotg" platforms
Thread-Index: AQHUJRxfzn89egir8kiZnHbl16+nLA==
Date:   Fri, 27 Jul 2018 11:11:15 +0000
Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE67@am04wembxa.internal.synopsys.com>
References: <20180726200730.18290-1-dianders@chromium.org>
 <20180726200730.18290-5-dianders@chromium.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/27/2018 12:08 AM, Douglas Anderson wrote:=0A=
> There's no reason to have the uframe scheduler off on dwc2.  Running=0A=
> with uframe_sched =3D False is equivalent to saying "I don't want to run=
=0A=
> the correct code, I want to run the old and incorrect code".=0A=
> =0A=
> The uframe scheduler has been off on stm32f4x9_fsotg since commit=0A=
> e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG=0A=
> HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so=0A=
> it's unclear to me why the uframe scheduler was left off.  Hopefully=0A=
> it's because someone copied it from other parameters and didn't think=0A=
> to try it?=0A=
> =0A=
> Presumably if everyone is good w/ the uframe_sched turned back on we=0A=
> can kill all the old and crufty non-uframe sched code.=0A=
> =0A=
> Signed-off-by: Douglas Anderson <dianders@chromium.org>=0A=
=0A=
Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>=0A=
=0A=
> ---=0A=
> =0A=
>   drivers/usb/dwc2/params.c | 1 -=0A=
>   1 file changed, 1 deletion(-)=0A=
> =0A=
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c=0A=
> index 93380f7c32b4..7be35bcde713 100644=0A=
> --- a/drivers/usb/dwc2/params.c=0A=
> +++ b/drivers/usb/dwc2/params.c=0A=
> @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dw=
c2_hsotg *hsotg)=0A=
>   	p->max_packet_count =3D 256;=0A=
>   	p->phy_type =3D DWC2_PHY_TYPE_PARAM_FS;=0A=
>   	p->i2c_enable =3D false;=0A=
> -	p->uframe_sched =3D false;=0A=
>   	p->activate_stm_fs_transceiver =3D true;=0A=
>   }=0A=
>   =0A=
> =0A=
=0A=