Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp693473imm; Fri, 27 Jul 2018 04:36:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdlbiaK+4ftXNwO+aNB9iAc8OJJYLnzHcOlNuqfBJ0svs2ATItlsX/nA/CkbKKHTVC2+4aL X-Received: by 2002:a62:f909:: with SMTP id o9-v6mr6306453pfh.141.1532691366695; Fri, 27 Jul 2018 04:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532691366; cv=none; d=google.com; s=arc-20160816; b=lXK/qvHnxpN2ghVLDv4ZK1jAJx3LCfodNIbZ3y0+m+bR17ihcKJWsyeIjLE4mtXQd5 EkrtcjN2v5Zg3fGjsJKiunEGdMVq8I7ChNAs/xudNJCzvxIb5Z8w4IlvGRS1M8WR09ja kbFUp3YZO09ez7VHOChDUvex76BXTn1yzbO8Ob/aP2xp2v7cfsFs5VlXNzZG1068+aOL GMByxH9wMy5oZZGF70D5u9pvG4+L0PxnfuVI2VfpgaL3GxNGlzLB6Sins3Eht3mI0t5G fFsiy14Fs/Faf9jUStBJXf06I4cifCfZC04R9SCJwfSlPQmpOBHfSmLm3Sx6/0i/phZh zteA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :domainkey-signature:dkim-signature:arc-authentication-results; bh=9jUPbJf3IdnMwa/PvQjlAEpfpsXd2BJw/BbFgCXhoWo=; b=gaY8ZUB/lMLqe0fGzeq5oTDhfuYkKPiqT3O+VudcXI9gG8zT9hiG7iVb0HCsiUTwjv QeMh5k4/8XKj7473tx/Rkl8qjfq6vhiwTBIE0aL0nDZjrJb7bBkLqXUK0jR7fCbRtDWo GDVR0zdxSXfIDEo4xqnfVKoXopZ9f57a3XnjXTlFzre2Ji5PvAiNk0OyGLRo6/5WwGWM xyF0NFWTfv45aVVditp1sYol3Q21IYcE9XyJ8grbX5i8hG60guj3Kr+ntJRKrZsYK8PD d0svoc2ZKxsjk8Qd8qZ41dgiYO873ZByl0SkD3OchIXQ8rydvZy4kQdUsR0tB3HkjaBj h5pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bidouilliste.com header.s=mail header.b=lBYa2NwO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9-v6si3714589pgn.177.2018.07.27.04.35.51; Fri, 27 Jul 2018 04:36:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bidouilliste.com header.s=mail header.b=lBYa2NwO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730981AbeG0M4M (ORCPT + 99 others); Fri, 27 Jul 2018 08:56:12 -0400 Received: from mail.blih.net ([212.83.177.182]:61474 "EHLO mail.blih.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730425AbeG0M4M (ORCPT ); Fri, 27 Jul 2018 08:56:12 -0400 Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 53f71e28; Fri, 27 Jul 2018 13:34:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=9vP1Dlcu3RCVipRmSaeg+cn4e7s=; b=lBYa2NwOSGg5MExpJ99rykF8TfB5 ytQxDT5sjCEcQyBnQ3J/kzEd5+/QNcWX9o9qCO+c5Cmv8eeoF+gjxEikE3PxHxwL m3IRijPCcaDxffUoT3QZaz1v/lO8KqXRxFHCm0V2Kg8uXpH2IXL0F+Fs/W4c3hv9 K88MsSM+7i846tU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=MYHCVUpfKX+WFLkDh1uiyW6TgzmTvaMuuVDjvQoy0s0BWn7X8ZNqzw/F yBQrmkgcVcDA1RiYMSHe0wfuadCwZcGbPA7e9C2y72rzN7m5IqYwGLFXTTN7YhHA W+5xTJZsT9wC7HNIMs/cN8d4Lpx4QQMN7yrIyqIifLMX05m0sRM= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 0c26672f TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 27 Jul 2018 13:34:39 +0200 (CEST) Date: Fri, 27 Jul 2018 13:34:39 +0200 From: Emmanuel Vadot To: Emmanuel Vadot Cc: Maxime Ripard , mark.rutland@arm.com, devicetree@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Emmanuel Vadot , wens@csie.org, robh+dt@kernel.org, srinivas.kandagatla@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5 Message-Id: <20180727133439.2f54a1a06d7a80560027cda3@bidouilliste.com> In-Reply-To: <20180727125654.ec813df71b492201aea2ca5f@bidouilliste.com> References: <20180724101522.68165-1-manu@freebsd.org> <20180724101522.68165-5-manu@freebsd.org> <20180724130004.ynaiabshexrrbvo4@flea> <20180724153432.e398bddfe63e51e8dcebfc46@bidouilliste.com> <20180724144218.jdvgrcqkz2kmohqx@flea> <20180724165501.d8f01bf20c7cc43e7ed7fc62@bidouilliste.com> <20180726115409.7hqtvx4rdqcqdjrq@flea> <20180727125654.ec813df71b492201aea2ca5f@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jul 2018 12:56:54 +0200 Emmanuel Vadot wrote: > On Thu, 26 Jul 2018 13:54:09 +0200 > Maxime Ripard wrote: > > > On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote: > > > On Tue, 24 Jul 2018 16:42:18 +0200 > > > Maxime Ripard wrote: > > > > > > > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote: > > > > > On Tue, 24 Jul 2018 15:00:04 +0200 > > > > > Maxime Ripard wrote: > > > > > > > > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote: > > > > > > > The SID controller on H5 look the same as the one present in the A64. > > > > > > > But in case we find some difference one day at a compatible string > > > > > > > of it's own and a fallback to the A64 one. > > > > > > > > > > > > > > Signed-off-by: Emmanuel Vadot > > > > > > > --- > > > > > > > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++ > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > > > > index 62d646baac3c..28183bf77164 100644 > > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > > > > @@ -129,3 +129,8 @@ > > > > > > > ; > > > > > > > compatible = "allwinner,sun50i-h5-pinctrl"; > > > > > > > }; > > > > > > > + > > > > > > > +&sid { > > > > > > > + compatible = "allwinner,sun50i-h5-sid", > > > > > > > + "allwinner,sun50i-a64-sid"; > > > > > > > +}; > > > > > > > > > > > > This is still a bit pointless, please remove the common node. > > > > > > > > > > You mean directly declare sid controller in the SoC dtsi and not > > > > > have a common node in sunxi-h3-h5.dtsi ? > > > > > > > > Yep > > > > > > The reason I've put it in the common file is because I'll send patches > > > for the nvmem-cells needed for thermal, and those are common between > > > the two. Other nvmem-cells are also common (like the chipid and > > > probably other). > > > > Then we'll see what we can have in common and what not when we'll have > > something in common? > > Will it make more sense that I just send a new series with nvmem-cells > now along with thermal bindings ? My bad, I remembered H5 thermal sensor being the same as H3 but I was wrong. I'll send a v3 with your changes suggestion and we'll see later for thermal sensor. > > Maxime > > > > -- > > Maxime Ripard, Bootlin (formerly Free Electrons) > > Embedded Linux and Kernel engineering > > https://bootlin.com > > > -- > Emmanuel Vadot > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Emmanuel Vadot