Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp704947imm; Fri, 27 Jul 2018 04:49:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe1k3W9DOQG6MbmKjh2YrqxWSNV2vwkV3qXdg5sfEudISjIkg9WX1j9fKnoTe9+kA/kR6Tc X-Received: by 2002:a62:2983:: with SMTP id p125-v6mr6412339pfp.128.1532692163513; Fri, 27 Jul 2018 04:49:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532692163; cv=none; d=google.com; s=arc-20160816; b=K23CW4Wz/82XnGT7awsTpNNKenvu/vKFr/IVBDCyIzbvOAJ/OCl6Cj788ssk67654v zeWNqdLIUHbcSUyBFJT85bK/AuHqz3SSbnDwf5lc5Vjne/pf9yoFehoM9Mr6n4JXCSAT ThHdylsU/xCF3+d8ofABaivlJCiZPQJhm8gydRrUcTx8SvPar1/6mj6Tw7kP4yYn1San DwoLryqDWsP8IPmIlMb1nsnsrfMJRC/fue15veoRCOgfBgxFQfDd8KgB05TY3O4n8aFn uulUWTawn3Zv2vk3Gbem/n4wIidKi3yyuNJRPCOoH2nP73Rhj6AdAJbetfmcszk48NPi BCFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=p6PnLLjntb/OeUUGR7klR1EecW8x9b49Ljf1EGdMCdU=; b=bBA12loS1fPalagJgWoCLfxqKZCntusyeZxQESQw0dz8Z+7zwIFq5k+AvkKmN0uv7o KpOdSYoVug5v7I1BQkyvyIQYIBoSUiR5WGEOc3+P1DQttbaO9frv1kdqd66DWpSgon6E +SJyxJSFK0WJIiYdbf2xs7MB/2YwBUpJ0SQGOaksU1/L3lxH924l9mtRyaxHkWIFt/20 ANqv9vkuYIohKxhCYuCOczQUaN+yvvIDr3sdyXngDrpzE5VyrmAf/Kfp9cwi1VXurqd1 Mp4Z4pJpEj6pTSsmh9KDCBAh5PQ/XuZOlJ1uYvkAPjUlsXL6TuyaZw7DzEcxa4psnG3V PUtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18-v6si3897467pfi.88.2018.07.27.04.49.08; Fri, 27 Jul 2018 04:49:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730510AbeG0NJv (ORCPT + 99 others); Fri, 27 Jul 2018 09:09:51 -0400 Received: from bran.ispras.ru ([83.149.199.196]:16167 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729541AbeG0NJv (ORCPT ); Fri, 27 Jul 2018 09:09:51 -0400 Received: from myklebust.intra.ispras.ru (unknown [10.10.2.207]) by smtp.ispras.ru (Postfix) with ESMTP id 996FC203B2; Fri, 27 Jul 2018 14:48:16 +0300 (MSK) From: Anton Vasilyev To: Helen Koike Cc: Anton Vasilyev , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] media: vimc: Remove redundant free Date: Fri, 27 Jul 2018 14:47:59 +0300 Message-Id: <20180727114759.10601-1-vasilyev@ispras.ru> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 4a29b7090749 ("[media] vimc: Subdevices as modules") removes vimc allocation from vimc_probe(), so corresponding deallocation on the error path tries to free static memory. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/media/platform/vimc/vimc-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/vimc/vimc-core.c b/drivers/media/platform/vimc/vimc-core.c index fe088a953860..9246f265de31 100644 --- a/drivers/media/platform/vimc/vimc-core.c +++ b/drivers/media/platform/vimc/vimc-core.c @@ -328,7 +328,6 @@ static int vimc_probe(struct platform_device *pdev) if (ret) { media_device_cleanup(&vimc->mdev); vimc_rm_subdevs(vimc); - kfree(vimc); return ret; } -- 2.18.0