Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp769689imm; Fri, 27 Jul 2018 05:56:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfJVfjcnyfdTy3Hq1pjKG9DOfZBRrcg35VqjTUQukLofJXvyyn8LZ3v0yitJtvM82vggUu4 X-Received: by 2002:a17:902:6946:: with SMTP id k6-v6mr6046397plt.268.1532696185815; Fri, 27 Jul 2018 05:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532696185; cv=none; d=google.com; s=arc-20160816; b=uP8TZPdK7zv31po+dc8s0sMZkJbhnl8UWxaQKZNLtYkb6nYY4wyOnMFWvjgdrd6jlH iKa5Q8Ttffw8Z1fcFFwYieTztfcCe7APR2EJvx6IXggGHbYfOHR0OymE4q/qSnFP0Ptz 1WWEIsuBpcbEiBQy6q0Neleqkx3AlsIymNAUFjosnp/8+xuZkMM1wqB5tTCk809HhBU9 hcpCaNrT1rJW3xVUO30Tz2nyc80z34SpQCvevRE0S1DncVZODSiCiiC/0LqgkQUEh0Yc 9ttcDuyQ4l/wHpVpwneYEkzOjkbLhSqtHcahRKM8R7CoZZ8Z2+F6b9+86NgkknoJ34mK VNGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=jUTNbHYRnUIb2W7l6BWjBLnwp/CBOY/K3lLJdfCnXi8=; b=u9TzS9eJXYKVZXkgruzAfIIN5kSlOaVhDwMHGbYl7if1RXoUKYl3lGMpCZI+HOnkQp MyypmuWkXzme7vA7LI67Q6Pval8aWhyDJXaKJJyxhTCIQgK60NGhLYY2lix/wIXjiX+b cciaJZ+cvV99gVKaaG4sdatUX1+1CQeMpPiFKd6whdIiLpZdhlLAef3ZoEyTG+/NcEQk nQ5er35RhRQ9lzMdlUcgmgV1EvqcY5t6umajXXNrZmFSBxGU6axdmRqaBlV9fKmJb3PC hPb9Vsp6CDZ3jPfBuvAdc7BqSURBE6vfnNa2rX5FxwPAUXZ5nlq51W/RdpknNCEetbaj YuUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t66-v6si3919479pfg.292.2018.07.27.05.56.10; Fri, 27 Jul 2018 05:56:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730907AbeG0ORL (ORCPT + 99 others); Fri, 27 Jul 2018 10:17:11 -0400 Received: from foss.arm.com ([217.140.101.70]:43182 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730314AbeG0ORL (ORCPT ); Fri, 27 Jul 2018 10:17:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6305E15AD; Fri, 27 Jul 2018 05:55:22 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 350A73F575; Fri, 27 Jul 2018 05:55:22 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id BA8441AE323F; Fri, 27 Jul 2018 13:55:22 +0100 (BST) Date: Fri, 27 Jul 2018 13:55:22 +0100 From: Will Deacon To: Stephen Rothwell Cc: Kees Cook , Linux-Next Mailing List , Linux Kernel Mailing List , Alexander Popov , Catalin Marinas , Laura Abbott Subject: Re: linux-next: build failure after merge of the kspp tree Message-ID: <20180727125522.GA6173@arm.com> References: <20180727190207.7ce1c9b0@canb.auug.org.au> <20180727190647.3525f5f7@canb.auug.org.au> <20180727205511.7c0f2e62@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180727205511.7c0f2e62@canb.auug.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2018 at 08:55:11PM +1000, Stephen Rothwell wrote: > On Fri, 27 Jul 2018 19:06:47 +1000 Stephen Rothwell wrote: > > > > On Fri, 27 Jul 2018 19:02:07 +1000 Stephen Rothwell wrote: > > > > > > After merging the kspp tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > cc1: error: plugin stackleak_plugin should be specified before -fplugin-arg-stackleak_plugin-disable in the command line > > > > > > Maybe caused by commit > > > > > > a8b9eaddb9c0 ("gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack") > > > > > > I have used the kspp tree from next-20180726 for today. > > > > Well, that obviously didn't work since the tree hasn't changed for a > > few days. > > > > I can't see what has interacted to make this happen, so I have dropped > > the kspp tree for today. > > Actually, it may have been caused by commit > > 0b3e336601b8 ("arm64: Add support for STACKLEAK gcc plugin") > > from the arm64 tree. Thanks, Stephen. I managed to reproduce this by merging for-next/kspp from Kees's tree and for-next/core from the arm64 tree. The failure happens when building the EFI stub, so the commit you mention above is almost certainly the culprit. We build the stub with the following GCC invocation: gcc -Wp,-MD,drivers/firmware/efi/libstub/.efi-stub-helper.o.d -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/4.9/include -I./arch/x86/include -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ -mcmodel=small -m64 -D__KERNEL__ -O2 -fPIC -fno-strict-aliasing -mno-red-zone -mno-mmx -mno-sse -fshort-wchar -DDISABLE_BRANCH_PROFILING -D__NO_FORTIFY -ffreestanding -fno-stack-protector -fplugin-arg-stackleak_plugin-disable -fno-builtin -DKBUILD_BASENAME='"efi_stub_helper"' -DKBUILD_MODNAME='"efi_stub_helper"' -c -o drivers/firmware/efi/libstub/.tmp_efi-stub-helper.o drivers/firmware/efi/libstub/efi-stub-helper.c so given that we're not passing any -fplugin= option anyway (because we override KBUILD_CFLAGS for the stub), I don't understand why we need to the disable option at all. Laura? Will