Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp777282imm; Fri, 27 Jul 2018 06:03:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeXH6JYqNlmkthq6MWGxOQC6QUDy6dIP62GyI1aH3IyIdcuj49z7JFBxrguHA5TiInjEMbF X-Received: by 2002:a62:3856:: with SMTP id f83-v6mr6654695pfa.48.1532696580966; Fri, 27 Jul 2018 06:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532696580; cv=none; d=google.com; s=arc-20160816; b=KJp/pv9+TR8l4Qs4ZFdC3dUUUCz1NgTklojqN9QTSmwcUGq6uNIen/3tYenNxID1e0 W02h5R4TRdfeJzBrka2MyGbv4K5Qdd4TTzBRHhdDFMC80DAZF0y0r8RjxHi99qgWJwk6 xM1s+zrBOmCtEQD27+/CUequZztRD4qcyZbT47bTIabg3qADd3io8JXMe1CcCx29wHWZ 3ppfrmquSXJ2j2dDUBuy1mj8SZWeKMxceYJXArkQ1mzUQzSa0sDuLJLiddYmpm7nX+fW OV/Gl4+/EHBPNTS3KXQB3KGVBPiGviEF+ji9M8bDJTO4R/HjyM1DaRyh3L5mGTSJ/G7P Amag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=JHYwpE92puqhjO7MT3utpoKE5de7rBOfXyADFb3tvrk=; b=DW7sQQEVHb2Q9jQ2CfDvCy673vHloKz+8fJrbrm87J3QqZROXgyYcAB5obONxNsAC2 DTnZSiVqPZyHCysy2GO/p3YsFryz2guTysZibiaW9yjU7SfugmHk6/1f3YUd08f21s5D xOWX7RAlIyYAU8Lk9Xc0mfCbeG4asvH3u1XLuDNJauQEKUFmim+1Z1gsPLtQp8Qzxlfz rme6VOW+QvzVvBWJz/AukJeH/yS0hjNG4bMKnPYYLkAb9brQNqeO24N8z+ZUrF4NSkEt RsYD+MrDzbr2Zl65FljBe7l6EVDoJjZffFKI+brgN+A5oZ1a/Rv0f3FEliTx+io6sov0 e7/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v28-v6si3915621pfi.22.2018.07.27.06.02.46; Fri, 27 Jul 2018 06:03:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388568AbeG0OW4 (ORCPT + 99 others); Fri, 27 Jul 2018 10:22:56 -0400 Received: from foss.arm.com ([217.140.101.70]:43298 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730561AbeG0OW4 (ORCPT ); Fri, 27 Jul 2018 10:22:56 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FA0715AD; Fri, 27 Jul 2018 06:01:06 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 60DDC3F575; Fri, 27 Jul 2018 06:01:06 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id E49BB1AE323F; Fri, 27 Jul 2018 14:01:06 +0100 (BST) Date: Fri, 27 Jul 2018 14:01:06 +0100 From: Will Deacon To: Stephen Rothwell Cc: Kees Cook , Linux-Next Mailing List , Linux Kernel Mailing List , Alexander Popov , Catalin Marinas , Laura Abbott Subject: Re: linux-next: build failure after merge of the kspp tree Message-ID: <20180727130106.GB6173@arm.com> References: <20180727190207.7ce1c9b0@canb.auug.org.au> <20180727190647.3525f5f7@canb.auug.org.au> <20180727205511.7c0f2e62@canb.auug.org.au> <20180727125522.GA6173@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180727125522.GA6173@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2018 at 01:55:22PM +0100, Will Deacon wrote: > On Fri, Jul 27, 2018 at 08:55:11PM +1000, Stephen Rothwell wrote: > > On Fri, 27 Jul 2018 19:06:47 +1000 Stephen Rothwell wrote: > > > > > > On Fri, 27 Jul 2018 19:02:07 +1000 Stephen Rothwell wrote: > > > > > > > > After merging the kspp tree, today's linux-next build (x86_64 > > > > allmodconfig) failed like this: > > > > > > > > cc1: error: plugin stackleak_plugin should be specified before -fplugin-arg-stackleak_plugin-disable in the command line > > > > > > > > Maybe caused by commit > > > > > > > > a8b9eaddb9c0 ("gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack") > > > > > > > > I have used the kspp tree from next-20180726 for today. > > > > > > Well, that obviously didn't work since the tree hasn't changed for a > > > few days. > > > > > > I can't see what has interacted to make this happen, so I have dropped > > > the kspp tree for today. > > > > Actually, it may have been caused by commit > > > > 0b3e336601b8 ("arm64: Add support for STACKLEAK gcc plugin") > > > > from the arm64 tree. > > Thanks, Stephen. I managed to reproduce this by merging for-next/kspp from > Kees's tree and for-next/core from the arm64 tree. The failure happens when > building the EFI stub, so the commit you mention above is almost certainly > the culprit. > > We build the stub with the following GCC invocation: > > gcc -Wp,-MD,drivers/firmware/efi/libstub/.efi-stub-helper.o.d -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/4.9/include -I./arch/x86/include -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ -mcmodel=small -m64 -D__KERNEL__ -O2 -fPIC -fno-strict-aliasing -mno-red-zone -mno-mmx -mno-sse -fshort-wchar -DDISABLE_BRANCH_PROFILING -D__NO_FORTIFY -ffreestanding -fno-stack-protector -fplugin-arg-stackleak_plugin-disable -fno-builtin -DKBUILD_BASENAME='"efi_stub_helper"' -DKBUILD_MODNAME='"efi_stub_helper"' -c -o drivers/firmware/efi/libstub/.tmp_efi-stub-helper.o drivers/firmware/efi/libstub/efi-stub-helper.c > > so given that we're not passing any -fplugin= option anyway (because we > override KBUILD_CFLAGS for the stub), I don't understand why we need > to the disable option at all. > > Laura? ... ah, but arm and arm64 inherit the old KBUILD_CFLAGS via the cflags-$(CONFIG_ARM64) and cflags-$(CONFIG_ARM) definitions, so they would be the places where we need to disable the plugin. Will