Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     "andrew@lunn.ch" <andrew@lunn.ch>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Camelia Alexandra Groza <camelia.groza@nxp.com>
Subject: RE: [PATCH] net: phy: use generic clause 45 autonegotiation done
Thread-Topic: [PATCH] net: phy: use generic clause 45 autonegotiation done
Thread-Index: AQHUHpkhRppx3uTn+EqPQRQZK8PlPqSjIJng
Date:   Fri, 27 Jul 2018 13:41:47 +0000
Message-ID: <AM0PR04MB478842A44CC90EC171E2AC54F22A0@AM0PR04MB4788.eurprd04.prod.outlook.com>
References: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com>
In-Reply-To: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9da44551-8cac-48da-a63b-08d5f3c6b350
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2018 13:41:47.9053
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4274
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Camelia Groza [mailto:camelia.groza@nxp.com]
> Sent: Wednesday, July 18, 2018 16:12
> To: andrew@lunn.ch; f.fainelli@gmail.com; davem@davemloft.net
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Camelia
> Alexandra Groza <camelia.groza@nxp.com>
> Subject: [PATCH] net: phy: use generic clause 45 autonegotiation done
>=20
> Only Clause 22 PHYs can use genphy_aneg_done(). Use
> genphy_c45_aneg_done() for PHYs that implement Clause 45 without the
> Clause 22 register set.
>=20
> This change follows the model of phy_restart_aneg() which differentiates
> between the two implementations in a similar way.
>=20
> Fixes: 41408ad519f7 ("net: phy: avoid genphy_aneg_done() for PHYs without
> clause 22 support")
> Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
> ---
>  drivers/net/phy/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index
> 537297d..4fcc703 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -151,7 +151,7 @@ int phy_aneg_done(struct phy_device *phydev)
>  	 * implement Clause 22 registers
>  	 */
>  	if (phydev->is_c45 && !(phydev->c45_ids.devices_in_package &
> BIT(0)))
> -		return -EINVAL;
> +		return genphy_c45_aneg_done(phydev);
>=20
>  	return genphy_aneg_done(phydev);
>  }
> --
> 1.9.1

Hi

A reminder for the original patch above. Since I sent the second patch for =
phy_config_aneg() against a different tree [1], I didn't see the need to re=
submit this patch. If you need me to resubmit it, please let me know.

[1] https://patchwork.ozlabs.org/patch/947831/

Thank you,
Camelia