Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp820613imm; Fri, 27 Jul 2018 06:45:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdGaFZjRYMWlq1Q2QTWvInbqB4XymMHo2zEJd5sN3sH7e9GhozvGub3ZwyhlEX6hHr7bLyU X-Received: by 2002:aa7:808f:: with SMTP id v15-v6mr6819145pff.38.1532699151263; Fri, 27 Jul 2018 06:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532699151; cv=none; d=google.com; s=arc-20160816; b=vhdM+z2b//5uBhRfzMl0NIIz+78KoKaf3kdEp67WE4efo2gftdsenFI2YIxDTk/PYD 2fxcqo4LKJSk1xqII7kyDoza2in8DIm/KuBQjOkI6gR0xP34nP/YB8t/CHnzJO3COWEK KnptdOJkdNcVgLbM0hwjOvXFLSk3NIvPO3clcUBpBREp7bjVP7b40SAJZ+/rBNg7v7+d KJ81B0E+L1ST4thCir+1T4YkhZBbQvCo7rxb+xZ7mYxJgSfS+82DkHv2GGITlenAooZe ZnEKrynRZha8BhJfJ0D92FBqthG25amY81AOK1REMzvYGM+4A8fMNUKyJqgNzyQzlxZR lHcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:arc-authentication-results; bh=sEDLB8eFVpHa+l9VCSECu/Pfniq11tvH7Va7zgjVWA8=; b=H6/Iy/lrpGaaze358x05rZl+/EidDBZ/kdomip1f73i3KNIE+L3sjtIM7cTAJn7XfQ lNuciUpj/maG6cdFzv65iBmr1bu91OYyHPjLzbwTR4e3RZK8qmUlTbXRs5IVQgD3N7DX bHIcZEImXUtTb0FON/autiXNlHgThMRU+2bnI5BNW9iX/2MPJWPnuQMXYGzXAumeSMW/ dNvvOKpg3kYygUDP9iK52nBEkDOqFzikKN1YqDL+Ud+cOojT7b9uV6yLu0SYXvtHSZbK E5z5U8UzqqciiZefklRG+36vpPkibY+vQm0vP9swLy1J2wn7S2hdfryxGkrrurOEdZ4L 2mfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=OxQJFQuP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t71-v6si3617138pgd.271.2018.07.27.06.45.36; Fri, 27 Jul 2018 06:45:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=OxQJFQuP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732112AbeG0PF2 (ORCPT + 99 others); Fri, 27 Jul 2018 11:05:28 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35238 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730698AbeG0PF2 (ORCPT ); Fri, 27 Jul 2018 11:05:28 -0400 Received: by mail-ed1-f67.google.com with SMTP id e6-v6so3968847edr.2 for ; Fri, 27 Jul 2018 06:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=sEDLB8eFVpHa+l9VCSECu/Pfniq11tvH7Va7zgjVWA8=; b=OxQJFQuPaCuQ2LvOMdrXOZtZiF39OcMCHoImHg76dHPB9Rz4JfnktQstXHz9yfYz25 cNVqV4eLuJS5gCkBTU4X4+tjKQIkJ4axju0DbYRH3yj8oqtO6b42+haLpS/QwcFUMD+E CtVW8YFnwKwhZxotxAYMrhO55hCL8kjNMDlVFdlA5MzI+FuMkUkE+t6d36F0oPjKQp3l rk1eUUhg5lVB2AbzEECo8s7hKWozI7UrcOkH4f4BD+TM+UiCznJq3FD1L0//cRfz0yXS vKTvr1VHcqHNjS+ygtXYF8MluyQhuRvEkytdMCX6rquG2r+WoR0jeqcc+Ih/xOtcW+YO Q8Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=sEDLB8eFVpHa+l9VCSECu/Pfniq11tvH7Va7zgjVWA8=; b=TpjCks+GbfctDTjvnae2N7gKRewSTxgvToUknUKgZsxMwyrERg3+Pca6L0EVR6nYJr cupb90l2mnEwxrLNB1WoFIaJ6UqMjGRSoG/lMuPQEqap8LDKRGo8Nu5/CN2Wz+Dta3Na 7Xnclc8pMipLwZ30zZ5ROHyVOarlOyfMhFCAtXYNil+2n2L1MpSielWjHJndIg1HFRCw z+MtyO4WWFkIIkgj6sh5gULUPSgqtvSqM7/P4D2JbGo2rUt2lFyAzGpQX1W6wzx9hwlx uB/qZ3OcrGNC0juVzesJ4rNb0sbGgXulB5C1CioFfBvc8jmRmOUDZneR+DwSj5bcrhjR kWIg== X-Gm-Message-State: AOUpUlFW48METpUiuigoiENY1VCQi+dYi740uqnnKaTwRs0GD5OeZGcn d0FS+RvlLjXiIgoqCvJbBpB8pg== X-Received: by 2002:aa7:c68b:: with SMTP id n11-v6mr7674779edq.122.1532699007003; Fri, 27 Jul 2018 06:43:27 -0700 (PDT) Received: from dhcp.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id a9-v6sm2124702edi.26.2018.07.27.06.43.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 06:43:25 -0700 (PDT) Message-ID: <1532699004.2679.9.camel@arista.com> Subject: Re: [PATCH 06/18] netlink: Do not subscribe to non-existent groups From: Dmitry Safonov To: David Miller Cc: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, steffen.klassert@secunet.com, 0x7f454c46@gmail.com, netdev@vger.kernel.org Date: Fri, 27 Jul 2018 14:43:24 +0100 In-Reply-To: <20180725.212258.182134114222639499.davem@davemloft.net> References: <20180726023144.31066-1-dima@arista.com> <20180726023144.31066-7-dima@arista.com> <20180725.212258.182134114222639499.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-07-25 at 21:22 -0700, David Miller wrote: > From: Dmitry Safonov > Date: Thu, 26 Jul 2018 03:31:32 +0100 > > > Make ABI more strict about subscribing to group > ngroups. > > Code doesn't check for that and it looks bogus. > > (one can subscribe to non-existing group) > > Still, it's possible to bind() to all possible groups with (-1) > > > > Cc: "David S. Miller" > > Cc: Herbert Xu > > Cc: Steffen Klassert > > Cc: netdev@vger.kernel.org > > Signed-off-by: Dmitry Safonov > > This really has nothing to do with adding a compat layer for xfrm, > and is a bug fix that should be submitted separately in it's own > right. Sure, will do. -- Thanks, Dmitry