Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp853129imm; Fri, 27 Jul 2018 07:16:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfh7IdbjbQvo9D9MX318EBTXx11mKRCe+buxAiYThFc4hKUXfTKm2gLUXYca5dGr1J9vfES X-Received: by 2002:a63:fc0a:: with SMTP id j10-v6mr6331192pgi.1.1532701001104; Fri, 27 Jul 2018 07:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532701001; cv=none; d=google.com; s=arc-20160816; b=LBAhbajOPWwo7AWh3QFlpo3q8NSHp7IobuhNkxZJPlp1TUdOEDURN54NjpFMSbkfnK Wa/l7f8vYOQ/fzEugEJKYiFKn/p/z8UoyoV93GalfezD4Iq/hf+ggdi68NN/ngWolGFE XeK3NVtDTDGubno3C0H4cpgo2y9BIL9D78KjHWocHijtbc7jo+cODAhamhs4N+pocMzn xlA9flI4Z1dQhak4dPpLueNO8KLNuTxaaIfL+3LLng6p6K0/23BFnsVqa5Iqd0TUYgLv 3sMvSyqvMJk0CE02f/9iFA460P3IwsibgTaGvdm/Qp/5D4AZC7ElGOEWCIe1ujutfHR5 qDiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:arc-authentication-results; bh=VOlQDfZY/tBlVh3AO8j6Uo7KIEVT31c94a2kw/Xw+9Y=; b=CT1O8MptdojDAsO7HpwO5vGhlTVr/9YiQkmJJBftU5yhrFWDItatL2o5HeeWUyQf5b Uwj9wPH64p4eXdUY19AAxplc3SmZ67CmKxjHWY3wBuszPMsu0EvUqttSj3wBsO/oBF3W zb+LLZ3zHTa1hEaPMSXsqE070IYjg59mi7tUDPpTO/QNnP2xD714g5RitRi7EwlLIXuO yDK5aNYGkd3oo2QAdYTBeFO0Ri0t2vLfRdrc2WAvyIKKBX3TIcG/DJnFFSlQgIzSDMJV 6GFgxLsscTRWytwSPXZH/7vnkLKj60iQqNR1nNejqumfQRgzzsoL3eTSlkGN7J7VA+qh 218A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b76-v6si4141555pfl.223.2018.07.27.07.16.23; Fri, 27 Jul 2018 07:16:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388540AbeG0Pgm (ORCPT + 99 others); Fri, 27 Jul 2018 11:36:42 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:45949 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730395AbeG0Pgm (ORCPT ); Fri, 27 Jul 2018 11:36:42 -0400 Received: from [192.168.90.67] (61.170.236.39) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 27 Jul 2018 22:14:38 +0800 Subject: Re: [PATCH v3 1/2] clk: meson: add DT documentation for emmc clock controller To: Rob Herring References: <20180712211244.11428-1-yixun.lan@amlogic.com> <20180712211244.11428-2-yixun.lan@amlogic.com> <20180724232917.GA27041@rob-hp-laptop> CC: , Jerome Brunet , Neil Armstrong , Kevin Hilman , Carlo Caione , Michael Turquette , Stephen Boyd , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Qiufang Dai , Jian Hu , , , , , From: Yixun Lan Message-ID: Date: Fri, 27 Jul 2018 22:14:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20180724232917.GA27041@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [61.170.236.39] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Rob On 07/25/2018 07:29 AM, Rob Herring wrote: > On Thu, Jul 12, 2018 at 09:12:43PM +0000, Yixun Lan wrote: >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add three clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Yixun Lan >> --- >> .../bindings/clock/amlogic,mmc-clkc.txt | 31 +++++++++++++++++++ >> .../clock/amlogic,meson-mmc-clkc.h | 16 ++++++++++ >> 2 files changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> create mode 100644 include/dt-bindings/clock/amlogic,meson-mmc-clkc.h > > Reviewed-by: Rob Herring > Thanks for the review! There is a discussion about dropping "meson-" prefix in the compatible string[1] So, I will send another version with the new compatible name adjusted from "amlogic,meson-axg-mmc-clkc" to "amlogic,axg-mmc-clkc".. probably also rename the dt-bindings header file to amlogc,mmc-clkc.h [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com Yixun