Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp903600imm; Fri, 27 Jul 2018 08:04:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcLFMLu89b3L+7c45MFGgAAgnzWSxZE0KxOTeytcHXLorizClm+QO7St3tduGCx+s6tL20j X-Received: by 2002:a63:da04:: with SMTP id c4-v6mr6232485pgh.398.1532703841814; Fri, 27 Jul 2018 08:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532703841; cv=none; d=google.com; s=arc-20160816; b=LPJwuaV8VxxQsia46g5cxyr/3ZDfBgLmBoTqmGzP8/C1MrduuEeg33QogkUGeIyhtm lzx7Wr4dzyceltctSdsx0Vod+P17AE4CiPAcu0/GH6V8817w+ctHQUn9F+sMrscbJrvS NdPm4Q6ufstJ8mExN8yavP0gB4WgSJmhjk+LTPgq+zrrAwh6/n2R0NurcgEpxalNn8G/ 3TO04mMJLZZIf5KZI1mDuNuXQGpZmqqPMCDEbHxz06fo17Q88r3r2f8wdcEVDiF2Veqt MCtBwRokwS94hgB1TUT3NxEYAPkDkV7F5WX31/d4aGeX8ztnjASTsSQGh2fcrASDqMWg llqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=6E2ocujsy+qFwidm3Vq0JiRWkhuR/rV5dKEavZPoia0=; b=cdMesOS/SHB/1v1gvnAJKsjqhgWXYyU2ayHeGdF+uZxYm2lGGDcZv0kKGtag10GdK1 O+AYpO70BVwuI9hbCWuLwkqghgan71ZyBSSPLjljxzGmDDx36JTH8mPD4SDeXLrZYjvn BAA+DAx5LGcvwuNIPJjQ0MU2ZhGU7iY8GghKtMNHASt+K+MPnjYi+0RndwgEmyU8Snur pPCAGHdkE5fA4u6owskxsuqcFuNjN6Of5fBFBW4/aKBChROm3IamlBgUCB2kIeLJ8Tu0 3uYUYOEaADGHNWKwz0QgWM5mb91NHk/NZreZIazVDJzAFuNeypKk6SdN31s/ACtICwLw EHDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JGHetoWW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5-v6si3732373pll.449.2018.07.27.08.03.45; Fri, 27 Jul 2018 08:04:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JGHetoWW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388507AbeG0QZN (ORCPT + 99 others); Fri, 27 Jul 2018 12:25:13 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:41997 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731974AbeG0QZM (ORCPT ); Fri, 27 Jul 2018 12:25:12 -0400 Received: by mail-yb0-f195.google.com with SMTP id c10-v6so2107953ybf.9 for ; Fri, 27 Jul 2018 08:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6E2ocujsy+qFwidm3Vq0JiRWkhuR/rV5dKEavZPoia0=; b=JGHetoWWQnEAcCqKnGigRqgllGFgFxrCXU4mwUbcOB9ThUPiE/9kaaJ/G5FPkbIv3y whSayC/PSB9jo1TgHy3DdrtGlvouWichtoIZyFzfZhv65oqrC/ULVNqqpIo47l9RoBPv pTqh2FkkhN8cBWpn1s6gI6TayQG7zoJNLMar0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6E2ocujsy+qFwidm3Vq0JiRWkhuR/rV5dKEavZPoia0=; b=Zho4WhliznIyg98WLPRPaABJ5FY8vMu8PdJDDIpJhoHiiwcrEBKOknjlOjJOGqnHyH 89Ntp2CaFP1IBcXTTruLO0yjLJwRTLzK9+Kjb+GlkZkk54LTom/vXfdXpZpOobabni7i zVFIQuG/8G4Vr5qgSRTMjzO1zHgYHeTHs8PQtEziqaDxaRYtNjh0JVeqDHPMWPke15v9 2Wdv4OdTSVvW/+dM6VdwNrfztwkL+3+BVdcwyRqfHoU3FBfFNjB5UEKzZtH5ctUUzxD6 yd0edHjbzSCieeyFcMWSiUsXvVuE0KxnBguAZh2sB164jUH+xHtRKvXc9Dz2PX90m4dk Z2gg== X-Gm-Message-State: AOUpUlF0JIVe6xPmwTD/g03hPdoBxVhNm8hDHgasdkdIDBI7LBF2qrv5 EXkforbC4oshBcn9kZeGXJIPF94FnyxaCkkMI4Gorw== X-Received: by 2002:a25:4754:: with SMTP id u81-v6mr3740099yba.54.1532703772812; Fri, 27 Jul 2018 08:02:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:e716:0:0:0:0:0 with HTTP; Fri, 27 Jul 2018 08:02:52 -0700 (PDT) In-Reply-To: <20180725111459.10800-1-yuehaibing@huawei.com> References: <20180725111459.10800-1-yuehaibing@huawei.com> From: Michael Chan Date: Fri, 27 Jul 2018 08:02:52 -0700 Message-ID: Subject: Re: [PATCH net-next] bnxt_en: combine 'else if' and 'else' into single branche To: YueHaibing Cc: David Miller , open list , Netdev , Vasundhara Volam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 4:14 AM, YueHaibing wrote: > The else-if branch and else branch set mac_ok to true similarly, > so combine the two into single else branch. > > Aslo add comments to explain the two conditions, which > from Michael Chan and Vasundhara Volam. > > Signed-off-by: YueHaibing Acked-by: Michael Chan Thanks.