Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Jul 2018 11:33:48 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Yi Wang <wang.yi59@zte.com.cn>
Cc:     tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, douly.fnst@cn.fujitsu.com, jgross@suse.com,
        ville.syrjala@linux.intel.com, len.brown@intel.com,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn,
        trivial@kernel.org
Subject: Re: [PATCH] x86/apic: fix two slight indenting
Message-ID: <20180727113348.331a49f7@gandalf.local.home>
In-Reply-To: <1532672103-32250-1-git-send-email-wang.yi59@zte.com.cn>
References: <1532672103-32250-1-git-send-email-wang.yi59@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <wang.yi59@zte.com.cn> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
> 
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
> ---
>  arch/x86/kernel/apic/apic.c   | 2 +-
>  arch/x86/kernel/apic/vector.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>  
>  	if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
>  		pr_warning("APIC timer disabled due to verification failure\n");
> -			return -1;
> +		return -1;
>  	}
>  
>  	return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
>  		pr_err("Managed startup irq %u, no vector available\n",
>  		       irqd->irq);
>  	}
> -       return ret;
> +	return ret;
>  }
>  
>  static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,