Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp955634imm; Fri, 27 Jul 2018 08:52:08 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd99F5jbL5/ppvb2FoVhLstbSMrVT6vApPGQpi+zEM1kvxnsdS+qIfcULl33g6XkAN6rWrx X-Received: by 2002:a17:902:8506:: with SMTP id bj6-v6mr6477310plb.210.1532706728911; Fri, 27 Jul 2018 08:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532706728; cv=none; d=google.com; s=arc-20160816; b=mF/bcu3jWcnDj4/k+s3JIu4n4pS4u14QF4FoOLO8uWuQEiwJcWJFTevDiy2MUlNYct YskIB0LVNvcCUgT7ivuGJUBr7p6aB/EvRG2F8GEJ8Xgj4HiH55oFp2zyKm6xGHopr7+s s3QNTcUF2mTn12AdKJcO6xqxsbE9tQE18OeYMRDzQhJNsVEpSKlx4j2FXBw6wytsbWwi Rbl9VrL6QVk6swrJnqsfbD1lFyxpXGwu1XXvMQnmvFCI3QwQg/HSzYqXDmeDemP9X5vq GwDzLkyhewWk2C1xtaALzfg8Aibt/5wNOGD2FmdN9xWYKi0sgZPQjpb9A2pjmKe8k06P bCmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=1ihEttiDPbIxcgxCXgqvakUFI1uxSEce/it2GYHFuIg=; b=kqMtFQXbyllRKCRq6wi3PgGEKm7BXfkpLrWccRKzFX9yzUh8846EYiP8vprTuMxrfm ls70lm0HyagKVzcdRR71DwBTOYlpN/VBw9tSWBuDn7m5CnofcGOvqHi7cZ+empHtm9MH VJI2va+eV/ZDYzjQc1o9ad8yWmvrZVzXEJrK2k8BqNjttPB/BsHVyhDxttng1Mwg35ub hSyedE8V182xnGAJVwcQ3xUYxwDWYhkwoXb/jUQfhqCVATFOMtBwUxT/WLu73Gl5mKrq sf165NhLpLGx1BeOQ0hZVzOWPRK2rMmCZkIpWCDQT3EOlMDmT+YUkYs/J71pTAublyML i8kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65-v6si4126712pfe.49.2018.07.27.08.51.53; Fri, 27 Jul 2018 08:52:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388785AbeG0RNb (ORCPT + 99 others); Fri, 27 Jul 2018 13:13:31 -0400 Received: from bran.ispras.ru ([83.149.199.196]:16116 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388568AbeG0RNb (ORCPT ); Fri, 27 Jul 2018 13:13:31 -0400 Received: from myklebust.intra.ispras.ru (unknown [10.10.2.207]) by smtp.ispras.ru (Postfix) with ESMTP id 5166D203B2; Fri, 27 Jul 2018 18:50:57 +0300 (MSK) From: Anton Vasilyev To: Wolfgang Grandegger Cc: Anton Vasilyev , Marc Kleine-Budde , "David S. Miller" , Martin Kelly , Martin Lederhilger , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect Date: Fri, 27 Jul 2018 18:50:42 +0300 Message-Id: <20180727155042.24582-1-vasilyev@ispras.ru> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ems_usb_probe() allocates memory for dev->tx_msg_buffer, but there is no its deallocation in ems_usb_disconnect. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/net/can/usb/ems_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c index 12ff0020ecd6..b7dfd4109d24 100644 --- a/drivers/net/can/usb/ems_usb.c +++ b/drivers/net/can/usb/ems_usb.c @@ -1072,6 +1072,7 @@ static void ems_usb_disconnect(struct usb_interface *intf) usb_free_urb(dev->intr_urb); kfree(dev->intr_in_buffer); + kfree(dev->tx_msg_buffer); } } -- 2.18.0