Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Jul 2018 18:17:07 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Anton Vasilyev <vasilyev@ispras.ru>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter
 pair
Message-ID: <20180727161707.GP10686@lunn.ch>
References: <20180727155747.24978-1-vasilyev@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180727155747.24978-1-vasilyev@ispras.ru>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
> in device, whereas mdio_mux_iproc_remove() restores md pointer by
> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
> 
> The patch replaces getter to platform_get_drvdata.
> 
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>

Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew