Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1068493imm; Fri, 27 Jul 2018 10:35:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdT/NipMgyXVFN0+LiiJuP5BpXGuT0AMdYENIxHxgV+5ZbOLzq0gmAdmO1hTkkDMoxN5aml X-Received: by 2002:a17:902:6acc:: with SMTP id i12-v6mr6866870plt.278.1532712916121; Fri, 27 Jul 2018 10:35:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532712916; cv=none; d=google.com; s=arc-20160816; b=onkHI/c3uCDTFiGk7FwJFs5dUMHR3k99HEtzF0QTj+alnU9Dr+aJ9fvXGalronaJ/S FG3g9iFrdmZenRhTjOxZaxpwMqoh+LgXTKONeGLV/BFBcLkKwlLGG0k2J8RVxRwkNCeD Caz+BfhJ3Irp7IwkIUsCPUps9+jdloleo3eiOPKzPoOxPcVr9jEYMVXVOHm2zvMx6UHE BdktvG2+pBqRHVVvSdvymY9pUKvyPuOnbRGPuYakt9XJTVFQoKA7o2Nj7owBPHoE9IUo hF9SQGzBzdHW/s72yML3Cfvonr5OYEFMLvBF2kzBtsb0e0E/VfibdTi5WazOrr9uA5ol 4kkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:arc-authentication-results; bh=7FBYSpNss1tEy6IVrjLmidkPHsJ5e5/FmHnPE+NGONo=; b=IRq65Ui7BgsrFDPRjIhd+qsXGBJbamaPXALXLjqjfA0Bz6KglahfhPCVQnXApYvzFp mvk2Qw8SgxKD4lSbOqoxoOMzF56vPsOgBka+lx9mWlSb/SmZsvmg3D1MrY8vaj8j6UUO eR5r5WRLUS8y88iRxiO+crTJSfBoBy0YRnILjXY6xQ4IMKBhz0AS208xcJPAEJl55nC5 Cds5kSoR/C8gWgT1QgEFulzr9GnH+vEVb0bs5icdVn9NU+hl8JWLK5AUIC5R4EK2N+i5 KojaxO7veHw+0+ZsMs6T0lfCJRM4uUfA/foXtcyjC9Q/BrR/GaiswhE9tzfETAbpDfOm LUxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v71-v6si4681779pfj.354.2018.07.27.10.35.01; Fri, 27 Jul 2018 10:35:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389650AbeG0S4d (ORCPT + 99 others); Fri, 27 Jul 2018 14:56:33 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388563AbeG0S4c (ORCPT ); Fri, 27 Jul 2018 14:56:32 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83D0477888; Fri, 27 Jul 2018 17:33:38 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD2101C5B9; Fri, 27 Jul 2018 17:33:37 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 20/38] cpuset: Use fs_context [ver #10] From: David Howells To: viro@zeniv.linux.org.uk Cc: Tejun Heo , torvalds@linux-foundation.org, dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 27 Jul 2018 18:33:37 +0100 Message-ID: <153271281729.9458.4276628254395229642.stgit@warthog.procyon.org.uk> In-Reply-To: <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> References: <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 27 Jul 2018 17:33:38 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 27 Jul 2018 17:33:38 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make the cpuset filesystem use the filesystem context. This is potentially tricky as the cpuset fs is almost an alias for the cgroup filesystem, but with some special parameters. This can, however, be handled by setting up an appropriate cgroup filesystem and returning the root directory of that as the root dir of this one. Signed-off-by: David Howells cc: Tejun Heo --- kernel/cgroup/cpuset.c | 66 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 52 insertions(+), 14 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 6d9f1a709af9..e6582b2f5144 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -38,7 +38,7 @@ #include #include #include -#include +#include #include #include #include @@ -315,26 +315,64 @@ static inline bool is_in_v2_mode(void) * users. If someone tries to mount the "cpuset" filesystem, we * silently switch it to mount "cgroup" instead */ -static struct dentry *cpuset_mount(struct file_system_type *fs_type, - int flags, const char *unused_dev_name, - void *data, size_t data_size) +static int cpuset_get_tree(struct fs_context *fc) { - struct file_system_type *cgroup_fs = get_fs_type("cgroup"); - struct dentry *ret = ERR_PTR(-ENODEV); + static const char opts[] = "cpuset,noprefix,release_agent=/sbin/cpuset_release_agent"; + struct file_system_type *cgroup_fs; + struct fs_context *cg_fc; + char *p; + int ret = -ENODEV; + + cgroup_fs = get_fs_type("cgroup"); if (cgroup_fs) { - char mountopts[] = - "cpuset,noprefix," - "release_agent=/sbin/cpuset_release_agent"; - ret = cgroup_fs->mount(cgroup_fs, flags, unused_dev_name, - mountopts, data_size); - put_filesystem(cgroup_fs); + ret = PTR_ERR(cgroup_fs); + goto out; + } + + cg_fc = vfs_new_fs_context(cgroup_fs, NULL, fc->sb_flags, fc->purpose); + put_filesystem(cgroup_fs); + if (IS_ERR(cg_fc)) { + ret = PTR_ERR(cg_fc); + goto out; } + + ret = -ENOMEM; + p = kstrdup(opts, GFP_KERNEL); + if (!p) + goto out_fc; + + ret = generic_parse_monolithic(fc, p, sizeof(opts) - 1); + kfree(p); + if (ret < 0) + goto out_fc; + + ret = vfs_get_tree(cg_fc); + if (ret < 0) + goto out_fc; + + fc->root = dget(cg_fc->root); + ret = 0; + +out_fc: + put_fs_context(cg_fc); +out: return ret; } +static const struct fs_context_operations cpuset_fs_context_ops = { + .get_tree = cpuset_get_tree, +}; + +static int cpuset_init_fs_context(struct fs_context *fc, + struct dentry *reference) +{ + fc->ops = &cpuset_fs_context_ops; + return 0; +} + static struct file_system_type cpuset_fs_type = { - .name = "cpuset", - .mount = cpuset_mount, + .name = "cpuset", + .init_fs_context = cpuset_init_fs_context, }; /*