Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1182631imm; Fri, 27 Jul 2018 12:34:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfKt7g5voPYneYZIeSNeTnSR7Fo5lFSStQlqOilyJx/3RV3NwKbzFyTE7+dbeDsIHYIhrta X-Received: by 2002:a62:ce0b:: with SMTP id y11-v6mr8000569pfg.95.1532720079283; Fri, 27 Jul 2018 12:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532720079; cv=none; d=google.com; s=arc-20160816; b=dvR+GPoXmTk7vs9B85XFz1/HiPiBo+Px7nKWEQ2sbhxrhM7PehqwG0YOKWH/hMyTW8 lb8RwOwMl7vViTT4ELTWr8b3Q4klbVU63XRT7V4SuAVO9xupXFu6+4i3eiMp20TkyB6o Zu2BG8LqrGN/zr6HBjmUGubxqRHw3Op0Ra1/5X7X424+iQaG8MxpimDcdkuMhEJC21F2 cZTcboIDU8HIt2xyS52Gi6+AVkifKLtJrsQPFGKvuNaG+q2aM2b6JdcaDrD58ku9DTWn 393wbuqrDJgq2nZb/WcAq9VjtB4ufSUyaONdipr+LsEcNmtuVo3okFej7/6G8oyV4y/s 1rbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=jHu5t61qbPmURwoQnOrANBl7MmZF78Ld+IOaPa4whKo=; b=tr5thfdDMA+YCabrGarYGkrjdYcaMWSF9BEHTe5k02WxLtj45b5T0wav7nd3xjZPyX pQEr/BqlDYWxZT33tBu/HP17KBYZq8kkbJJ2aFewtz/7pTP5xGdp2Q5DDg7tea0FBTuE +vpSZTCQD2LCceDDCvInB/buNfEiidbpu5e5TVFC8wyEdwKUwOBU3mU16Nqg/cUwg3aA YATjeWus4sDylixN1oFF4hE+KpcxhmJazNS/nD6DQN+W6cVDTBaqVMi4dOJ6N9nqU8bd h0XPHLqwC3V4hmh7//IM3LfB/i7o8/hxd0nTOk9inTz1xgI5EpV05DyHvQJQSrFLmbAJ WocQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1-v6si4190194pli.472.2018.07.27.12.34.23; Fri, 27 Jul 2018 12:34:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389266AbeG0U4z (ORCPT + 99 others); Fri, 27 Jul 2018 16:56:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388467AbeG0U4y (ORCPT ); Fri, 27 Jul 2018 16:56:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4430F4219DA6; Fri, 27 Jul 2018 19:33:35 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36DAB21568A1; Fri, 27 Jul 2018 19:33:34 +0000 (UTC) Date: Fri, 27 Jul 2018 15:33:33 -0400 From: Mike Snitzer To: Huaisheng Ye Cc: linux-nvdimm@lists.01.org, dan.j.williams@intel.com, axboe@kernel.dk, linux-s390@vger.kernel.org, dave.jiang@intel.com, martin.petersen@oracle.com, vishal.l.verma@intel.com, chengnt@lenovo.com, linux-fsdevel@vger.kernel.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, willy@infradead.org, colyli@suse.de, bart.vanassche@wdc.com, dm-devel@redhat.com, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, schwidefsky@de.ibm.com, jack@suse.cz, ross.zwisler@linux.intel.com, agk@redhat.com, Huaisheng Ye Subject: Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required Message-ID: <20180727193333.GA23266@redhat.com> References: <20180725162849.8320-1-yehs2007@zoho.com> <20180725162849.8320-6-yehs2007@zoho.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725162849.8320-6-yehs2007@zoho.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 27 Jul 2018 19:33:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 27 Jul 2018 19:33:35 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25 2018 at 12:28pm -0400, Huaisheng Ye wrote: > From: Huaisheng Ye > > Function persistent_memory_claim doesn't need to get local pointer > dummy_addr from direct_access. Using NULL instead of having to pass > in a useless local pointer that caller then just throw away. > > Suggested-by: Ross Zwisler > Signed-off-by: Huaisheng Ye Acked-by: Mike Snitzer