Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1234527imm;
        Fri, 27 Jul 2018 13:33:14 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpcKfOxOWKpFpVuUFs2I7Xw8fxUU4DBb3jXYlSbjiZ0z5jm4POCAj7z2vgkvZPrJWD/Pje9n
X-Received: by 2002:a62:5d55:: with SMTP id r82-v6mr8121945pfb.150.1532723594426;
        Fri, 27 Jul 2018 13:33:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1532723594; cv=none;
        d=google.com; s=arc-20160816;
        b=VlLXj9L3KLgwS+nJmG6+ANmVFbo1da4zW3QZHXK31cPCvVILhGMHdguONxu3zHPlK+
         Ss/iClpmLOGRHu5KjRX6D+iDMTrZgJcBHrYXG70DJaydBkRBAgfGGnG9tzUJMhoKAroy
         jNiooOXw8SF+k+Nvl6lMlSizIexO10Amayo9h6YnQhLSyuRRUkerkeNUgoU6htDyn4n+
         WOdoDIh/G9rqjIZCujMZ7+4aiCAtKSdNfBpMvBNZuzpCnB5VBRsJ55cq/fJNqeEgqJbI
         IkbQP8FjjvVRBxu8yMTkNqFztPo1yu+lK9HMLIsCp8m6iWImDBqtkehvIAKo5TWU9f13
         nN5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature:arc-authentication-results;
        bh=E1OHhHlXKr/sMgtGidslBz87k/Wun/mjYBYwvCAVnmk=;
        b=luXe/jHeLe7+3awmi3CEZO7t8ix9eG5gGyxVoCn3DG5DW0F8e48gLXJYQz1x0wGwef
         IZQaijwaT9L04oOb8JkKfqINzYOHaCB2zaPTGyFQXRQxNM4Bk7Q/ufiKDJXe/3S7/KWw
         2o9Uwf3Cbs7UIBIz4Q615MRwmN1AdPC4BnaHgoyEyMOdXSzmgq+j7N81ijXzezNc3l1P
         Dj/VzTmR2E7j3NdjhdTMUd54/HOk7yLTcYHn57pTAv04FOzBXvvn0Pt8Z3Noz/G+9WEF
         WByo2JPPUBO31QhmSNppiHL5qnFacKOa7jojuiJ+KxRPpK+DJQHoXPTy9hMiuEAivx+p
         nRjg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=oIiuV5WH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q5-v6si4534172pgn.95.2018.07.27.13.32.59;
        Fri, 27 Jul 2018 13:33:14 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=oIiuV5WH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389647AbeG0Vzm (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others);
        Fri, 27 Jul 2018 17:55:42 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:48935 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2389368AbeG0Vzl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Jul 2018 17:55:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124;
        h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=E1OHhHlXKr/sMgtGidslBz87k/Wun/mjYBYwvCAVnmk=;
        b=oIiuV5WHn0twYl8l4OkGX614vSZkMCwf9HQh6pyH482/1l/YfLTKTZOwG/iJmma1m9cxtMSTHlZ0q4bZwO7MrU+b9Nou7w6bKG6pgGAbvAOqFvvVzl1R8Hdvd44rjxso+DXmUC1vH+5KNEgu9/W1LblikRDsRjLqZM0btVhFz0Y=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2)
        (envelope-from <andrew@lunn.ch>)
        id 1fj9P9-0004wv-DJ; Fri, 27 Jul 2018 22:32:03 +0200
Date:   Fri, 27 Jul 2018 22:32:03 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc:     grygorii.strashko@ti.com, davem@davemloft.net,
        linux-omap@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily
 macroses on functions
Message-ID: <20180727203203.GB17441@lunn.ch>
References: <20180727191318.18698-1-ivan.khoronzhuk@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180727191318.18698-1-ivan.khoronzhuk@linaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static inline void cpsw_src_port_detect(struct cpsw_common *cpsw, int status,
> +					struct sk_buff *skb)

Please don't use inline. Let the compiler decide.

       Andrew