Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1248514imm; Fri, 27 Jul 2018 13:51:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc0T+sT0y/WhF5OJdV1es4RQehtRMvduMzl4W+W3lafGHmwfoIDi1c0hpJAdYN47LTfH1M+ X-Received: by 2002:a17:902:760d:: with SMTP id k13-v6mr7325478pll.56.1532724666167; Fri, 27 Jul 2018 13:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532724666; cv=none; d=google.com; s=arc-20160816; b=UIVzx+yiALMCy1SOckMxJni0czDe1PhO29wA9kBAJGww6yZ5HMLH1Yb5QOhAMWe0UF FPQGt6eAgEm0oQCNr5caP6eJiwm9SZ1qik5YySGcUm5zPYvUuANbg+EXID2yrL4lrx81 HoGgwwS5H3VljzX+7mzCifZBijCROpaJ8fzvy+IFaVNTMqhRu8BJ/KefFJRt+ytq1R9m PIyhjjwhoOxDAdklLAD9dsLitRZ+Ms+K58tdDc8ETqkGfehG2295oZNWnMZT/BlulaZ8 5sLXCdAkJQ8r8tpK+m6FuIg19MiFi1cv13omJ5O+Sw1+MDxNKoprgszwaKZT+u/AJWd0 2cpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=/QJWZlYHIDgL0FeyaIGnkpso5IArjmSJPu3XTkHeYpU=; b=vu4e0seQVGhiRn+9LNKcQcbaL47eOdkFq9PacGnBpGAvODz8GKuDUigUtfLlu/eM5Z tGWvW6bVxXINnhBSscXxESYDHvh+NKMdZ1pqFtxpnWiUpxT7RQHnRGr7FP+XB82d6L/X /nZx2Hz9PjDxPZYFS2SwBegvmkJq9+Qd763hNRjA5MSg9SyjFGP0ApQjIxVmcYrdKMeh 18ErDddwukxP4VEEMv64hRvPq0i6/vrr66TOUAy9Go7Zn1o1v43hVfnW2xObM4Cx9H4D RvDkCv8BXxgavgDO477Sx4t2lXmaQmEVi451+j7t6hkjLPtJT36VUTFCtyIUBNj0oaWP LbwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GxUF/0dS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5-v6si4183983plr.75.2018.07.27.13.50.51; Fri, 27 Jul 2018 13:51:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GxUF/0dS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389686AbeG0WNc (ORCPT + 99 others); Fri, 27 Jul 2018 18:13:32 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46417 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389317AbeG0WNb (ORCPT ); Fri, 27 Jul 2018 18:13:31 -0400 Received: by mail-lf1-f65.google.com with SMTP id l16-v6so4373656lfc.13 for ; Fri, 27 Jul 2018 13:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/QJWZlYHIDgL0FeyaIGnkpso5IArjmSJPu3XTkHeYpU=; b=GxUF/0dS36A5i4XrBcawVWSBgq5k+QN5AsQhMvmVFS3FdpUPZr0XmW3ZzeloSRd1la il23bdWv1r3ivVODJcdvquQ0n0Eas90ZzzUjubh8EiDOAyR2oK/c7jJ9L09yos1xuCt8 uNMV004I0Hr2t7hzgJsw9zzKg1dzvnYdzw8Fc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=/QJWZlYHIDgL0FeyaIGnkpso5IArjmSJPu3XTkHeYpU=; b=WypQSein3mHzV2AKuJoG/GyHhz7C6WULvkTt25AXjuDYip1L3bh2V+q2Ptt9PSXRou kMNb8bU6uJsJXc/ywHaNqUOpmzbPnUnqirxRiNIpWyLk/1dQwpc1e0ktNj5yyuT/S3rV gOquvelacRiLdTcURE7pvJrqI7Hyn3PzFBjUvcxzAG5Algvg+tP44HZXBqjMQC/rL8xz ey7fKcQKm6XxNUDUwVK4ZVd7453Z3NyI9StBGjNw+x6PL5pB7myfur4mLEDElXlMkpmz MEYj3T2/Zh1J4zyvC6iSuhGoM+BIgL35YMX/wsNs9eRRsmVSKyMNHLS1UpLobE5B33Iu 3ppA== X-Gm-Message-State: AOUpUlGdpMHRNkcpn1eBYfRoKNhPJ2GkThiGRHW6smYsuqEc7x2uK49R m68+oUqvi2KnDvZSTQqwzatcbA== X-Received: by 2002:a19:1c81:: with SMTP id c123-v6mr5124230lfc.105.1532724594201; Fri, 27 Jul 2018 13:49:54 -0700 (PDT) Received: from khorivan (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id w2-v6sm814181lje.73.2018.07.27.13.49.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 13:49:53 -0700 (PDT) Date: Fri, 27 Jul 2018 23:49:51 +0300 From: Ivan Khoronzhuk To: Andrew Lunn Cc: grygorii.strashko@ti.com, davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions Message-ID: <20180727204950.GD2619@khorivan> Mail-Followup-To: Andrew Lunn , grygorii.strashko@ti.com, davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180727191318.18698-1-ivan.khoronzhuk@linaro.org> <20180727203203.GB17441@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180727203203.GB17441@lunn.ch> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2018 at 10:32:03PM +0200, Andrew Lunn wrote: >> +static inline void cpsw_src_port_detect(struct cpsw_common *cpsw, int status, >> + struct sk_buff *skb) > >Please don't use inline. Let the compiler decide. > > Andrew Corrected in v2 -- Regards, Ivan Khoronzhuk