Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Jul 2018 14:12:16 -0700 (PDT)
Message-Id: <20180727.141216.2218815863913834329.davem@davemloft.net>
To:     baijiaju1990@gmail.com
Cc:     yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        linyunsheng@huawei.com, joe@perches.com, pombredanne@nexb.com,
        bianpan2016@163.com, shenjian15@huawei.com, keescook@chromium.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hisilicon: hns: Replace mdelay() with msleep()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180727080141.3079-1-baijiaju1990@gmail.com>
References: <20180727080141.3079-1-baijiaju1990@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 27 Jul 2018 16:01:41 +0800

> hns_ppe_common_init_hw() and hns_xgmac_init() are never 
> called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied.